third_party/WebKit/LayoutTests/external/wpt/clipboard/async-rw-dt-text-manual.html - Issue 2695593006: Initial stub version of Async Clipboard API

Side by Side Diff: third_party/WebKit/LayoutTests/external/wpt/clipboard/async-rw-dt-text-manual.html

Issue 2695593006: Initial stub version of Async Clipboard API (Closed)

Patch Set: Add WPTs; Update naming conventions; Review comments Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« third_party/WebKit/LayoutTests/external/wpt/clipboard/async-001.html ('K') | « third_party/WebKit/LayoutTests/external/wpt/clipboard/async-001.html ('k') | third_party/WebKit/LayoutTests/external/wpt/clipboard/async-rw-text-manual.html » ('j') | third_party/WebKit/LayoutTests/external/wpt/clipboard/async-rw-text-manual.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <meta charset="utf-8">

	3 <title>Async Clipboard write/read (DataTransfer/text) tests</title>

	4 <script src="/resources/testharness.js"></script>

	5 <script src="/resources/testharnessreport.js"></script>

	6 <script>

	7 async_test(function(t) {

	8 var test_data = "Exciting DataTransfer/text clipboard data";

	9 var cb = navigator.clipboard;

	10 var dt = new DataTransfer();

	11 dt.items.add(test_data, "text/plain");

	12

	13 cb.write(dt).then(function() {
	foolip 2017/05/15 15:33:27 The spec says "Handle access permissions. Reject p The spec says "Handle access permissions. Reject promise if not allowed". Does that mean that a user gesture check is planned? garykac 2017/05/17 23:51:14 We have a clipboard Permission[1] that is not yet Show quoted text On 2017/05/15 15:33:27, foolip wrote: > The spec says "Handle access permissions. Reject promise if not allowed". Does > that mean that a user gesture check is planned? We have a clipboard Permission[1] that is not yet implemented [1] https://w3c.github.io/permissions/#clipboard
	14 cb.read().then(function(data) {

	15 t.step(function(){assert_equals(data.items.length, 1);});
	foolip 2017/05/15 15:33:27 None of the explicit t.step should be required. In None of the explicit t.step should be required. Instead, wrap each callback function in t.step_func, e.g.: cb.write(dt).then(t.step_func(() => { cb.read().then(t.step_func(data => { .... })); }); It could well be that using promise_test simplifies the test by avoiding the t.ste_func bits, but async_test is fine as long as the indentation doesn't get out of hand. With those changes, you should be able to write a bare assert_equals(data.items.length, 1) here. garykac 2017/05/17 23:51:14 Done. Thanks! That looks nicer. Show quoted text On 2017/05/15 15:33:27, foolip wrote: > None of the explicit t.step should be required. Instead, wrap each callback > function in t.step_func, e.g.: > > cb.write(dt).then(t.step_func(() => { > cb.read().then(t.step_func(data => { .... })); > }); > > It could well be that using promise_test simplifies the test by avoiding the > t.ste_func bits, but async_test is fine as long as the indentation doesn't get > out of hand. > > With those changes, you should be able to write a bare > assert_equals(data.items.length, 1) here. Done. Thanks! That looks nicer.
	16 data.items[0].getAsString(function(s) {

	17 t.step(function(){assert_equals(s, test_data);});

	18 t.done();
	foolip 2017/05/15 15:33:27 This'll be the final and only t.done(). It doesn't This'll be the final and only t.done(). It doesn't matter, but when you prefer you can combine it with the last step with t.step_func_done(...) and still have asserts in the dot-dot-dot bit. garykac 2017/05/17 23:51:14 Acknowledged. Show quoted text On 2017/05/15 15:33:27, foolip wrote: > This'll be the final and only t.done(). It doesn't matter, but when you prefer > you can combine it with the last step with t.step_func_done(...) and still have > asserts in the dot-dot-dot bit. Acknowledged.
	19 });

	20 }, function() {

	21 t.step(function(){assert_false(true, "Read fail");});
	foolip 2017/05/15 15:33:27 If you stick with async_test you can use t.unreach If you stick with async_test you can use t.unreached_func("Read fail") here, and with promise_test a promise rejection is automatically a test failure. garykac 2017/05/17 23:51:14 Done. Show quoted text On 2017/05/15 15:33:27, foolip wrote: > If you stick with async_test you can use t.unreached_func("Read fail") here, and > with promise_test a promise rejection is automatically a test failure. Done.
	22 t.done();

	23 });

	24 }, function() {

	25 t.step(function(){assert_false(true, "Write fail");});

	26 t.done();

	27 });

	28 }, "Verify write and read clipboard (DataTransfer/text)");

	29 </script>

	30 Note: This is a manual test because it writes/reads to the shared system
	foolip 2017/05/15 15:33:27 Can you file bugs on web-platform-tests with type: Can you file bugs on web-platform-tests with type:untestable that describes what testing infrastructure would be needed to test this in an automated fashion across browsers? garykac 2017/05/17 23:51:14 Filed: https://github.com/w3c/web-platform-tests/i Show quoted text On 2017/05/15 15:33:27, foolip wrote: > Can you file bugs on web-platform-tests with type:untestable that describes what > testing infrastructure would be needed to test this in an automated fashion > across browsers? Filed: https://github.com/w3c/web-platform-tests/issues/5970
	31 clipboard and thus cannot be run async with other tests that might interact

	32 with the clipboard.

OLD	NEW