third_party/WebKit/LayoutTests/external/wpt/clipboard/async-001.html - Issue 2695593006: Initial stub version of Async Clipboard API

Side by Side Diff: third_party/WebKit/LayoutTests/external/wpt/clipboard/async-001.html

Issue 2695593006: Initial stub version of Async Clipboard API (Closed)

Patch Set: Add WPTs; Update naming conventions; Review comments Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/external/wpt/clipboard/async-rw-dt-text-manual.html » ('j') | third_party/WebKit/LayoutTests/external/wpt/clipboard/async-rw-dt-text-manual.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <meta charset="utf-8">

	3 <title>Async Clipboard basic tests</title>
	foolip 2017/05/15 15:33:27 Can you put this test under wpt/clipboard-apis/, t Can you put this test under wpt/clipboard-apis/, to match the shortname of https://w3c.github.io/clipboard-apis/? Also, can you name it navigator-clipboard-basics.html or something similar to avoid the number in the name? It's not uncommon in wpt, but also not very helpful unless tests for the same API grow so big that they must be split to run fast enough. garykac 2017/05/17 23:51:13 Done. Show quoted text On 2017/05/15 15:33:27, foolip wrote: > Can you put this test under wpt/clipboard-apis/, to match the shortname of > https://w3c.github.io/clipboard-apis/ > > Also, can you name it navigator-clipboard-basics.html or something similar to > avoid the number in the name? It's not uncommon in wpt, but also not very > helpful unless tests for the same API grow so big that they must be split to run > fast enough. Done.
	4 <script src="/resources/testharness.js"></script>

	5 <script src="/resources/testharnessreport.js"></script>

	6 <script>

	7 test(function() {

	8 assert_not_equals(navigator.clipboard, undefined);
	foolip 2017/05/15 15:33:27 Can you also assert_true(navigator.clipboard insta Can you also assert_true(navigator.clipboard instanceof Clipboard) and assert_equals(navigator.clipboard, navigator.clipboard)? foolip 2017/05/15 15:42:08 Actually, the existing line could be turned into a Show quoted text On 2017/05/15 15:33:27, foolip wrote: > Can you also assert_true(navigator.clipboard instanceof Clipboard) and > assert_equals(navigator.clipboard, navigator.clipboard)? Actually, the existing line could be turned into an idlharness.js test. Can you create interfaces/clipboard-apis.idl and write an idlharness.js test? https://github.com/w3c/web-platform-tests/pull/5903 is one I did recently. garykac 2017/05/17 23:51:13 Done. Show quoted text On 2017/05/15 15:42:08, foolip wrote: > On 2017/05/15 15:33:27, foolip wrote: > > Can you also assert_true(navigator.clipboard instanceof Clipboard) and > > assert_equals(navigator.clipboard, navigator.clipboard)? > > Actually, the existing line could be turned into an idlharness.js test. Can you > create interfaces/clipboard-apis.idl and write an idlharness.js test? > https://github.com/w3c/web-platform-tests/pull/5903 is one I did recently. Done. garykac 2017/05/17 23:51:13 Done. Show quoted text On 2017/05/15 15:33:27, foolip wrote: > Can you also assert_true(navigator.clipboard instanceof Clipboard) and > assert_equals(navigator.clipboard, navigator.clipboard)? Done.
	9 }, "Verify navigator.clipboard exists");
	foolip 2017/05/15 15:33:27 Nit: the leading "Verify " of all descriptions can Nit: the leading "Verify " of all descriptions can be removed. garykac 2017/05/17 23:51:13 Done. Show quoted text On 2017/05/15 15:33:27, foolip wrote: > Nit: the leading "Verify " of all descriptions can be removed. Done.
	10

	11 promise_test(function() {

	12 var dt = new DataTransfer();

	13 dt.items.add("Howdy", "text/plain");

	14 return navigator.clipboard.write(dt);

	15 }, "Verify navigator.clipboard.write(DataTransfer) succeeds");
	foolip 2017/05/15 15:33:27 Can you add a test for things that should not succ Can you add a test for things that should not succeed, in particular navigator.clipboard.write(null)? and navigator.clipboard.write("string")? garykac 2017/05/17 23:51:13 Done. Show quoted text On 2017/05/15 15:33:27, foolip wrote: > Can you add a test for things that should not succeed, in particular > navigator.clipboard.write(null)? and navigator.clipboard.write("string")? Done.
	16

	17 promise_test(function() {

	18 return navigator.clipboard.writeText("New clipboard text");

	19 }, "Verify navigator.clipboard.writeText(DOMString) succeeds");

	20

	21 promise_test(function() {

	22 return navigator.clipboard.read();
	foolip 2017/05/15 15:33:27 Also assert some things about the value with which Also assert some things about the value with which the promise resolves. It should be a DataTransfer instance, etc. garykac 2017/05/17 23:51:13 Done. Show quoted text On 2017/05/15 15:33:27, foolip wrote: > Also assert some things about the value with which the promise resolves. It > should be a DataTransfer instance, etc. Done.
	23 }, "Verify navigator.clipboard.read() succeeds");

	24

	25 promise_test(function() {

	26 return navigator.clipboard.readText();
	foolip 2017/05/15 15:33:26 Ditto. Ditto. garykac 2017/05/17 23:51:13 Done. Show quoted text On 2017/05/15 15:33:26, foolip wrote: > Ditto. Done.
	27 }, "Verify navigator.clipboard.readText() succeeds");

	28 </script>

OLD	NEW