chrome/browser/chrome_content_browser_client.cc - Issue 2695563002: Do not build share_service_impl and associated test on Mac/Android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chrome_content_browser_client.cc

Issue 2695563002: Do not build share_service_impl and associated test on Mac/Android. (Closed)

Patch Set: chrome_content_browser_client: Only include the header on Linux and Windows. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chrome_content_browser_client.cc

diff --git a/chrome/browser/chrome_content_browser_client.cc b/chrome/browser/chrome_content_browser_client.cc

index d1a18640e8a7e9d2731e9fa0f26671a691506f92..cb440054325a31a5334bfb27c3bd22c8b62fe89c 100644

--- a/chrome/browser/chrome_content_browser_client.cc

+++ b/chrome/browser/chrome_content_browser_client.cc

@@ -95,7 +95,6 @@

#include "chrome/browser/ui/webui/chrome_web_ui_controller_factory.h"

#include "chrome/browser/ui/webui/log_web_ui_url.h"

#include "chrome/browser/usb/usb_tab_helper.h"

-#include "chrome/browser/webshare/share_service_impl.h"

#include "chrome/common/channel_info.h"

#include "chrome/common/chrome_constants.h"

#include "chrome/common/chrome_features.h"

@@ -251,6 +250,7 @@

#if defined(OS_LINUX) || defined(OS_CHROMEOS) || defined(OS_WIN)

Sam McNally 2017/02/13 00:27:33 Can we remove the OS_CHROMEOS here? It would be ni

Matt Giuca 2017/02/13 00:32:42 Done. (I thought about doing this but didn't want

#include "chrome/browser/payments/payment_request_factory.h"

+#include "chrome/browser/webshare/share_service_impl.h"

#endif

#if defined(OS_POSIX) && !defined(OS_MACOSX)

« no previous file with comments | « chrome/browser/BUILD.gn ('k') | chrome/test/BUILD.gn » ('j') | no next file with comments »