Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: ui/base/l10n/l10n_util_win_unittest.cc

Issue 2695523002: Fix font sizes being incorrect when using --force-device-scale-factor. (Closed)
Patch Set: move to screen_win Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/base/l10n/l10n_util_win_unittest.cc
diff --git a/ui/base/l10n/l10n_util_win_unittest.cc b/ui/base/l10n/l10n_util_win_unittest.cc
index 2f1da59247164f7734cf15ee4d6661993991e6ac..efa8b62b40e0f20f621661b8aecae17cd332d5ce 100644
--- a/ui/base/l10n/l10n_util_win_unittest.cc
+++ b/ui/base/l10n/l10n_util_win_unittest.cc
@@ -6,9 +6,13 @@
#include <windows.h>
+#include "base/command_line.h"
#include "base/win/win_util.h"
#include "testing/gtest/include/gtest/gtest.h"
#include "testing/platform_test.h"
+#include "ui/display/display.h"
+#include "ui/display/display_switches.h"
+#include "ui/display/win/dpi.h"
typedef PlatformTest L10nUtilWinTest;
@@ -34,3 +38,19 @@ TEST_F(L10nUtilWinTest, TestDPIScaling) {
l10n_util::AdjustUIFontForDIP(1.8f, &lf);
EXPECT_NEAR(size, lf.lfHeight, 1);
}
+
+// Test for crbug.com/675933. Since font size is a Windows metric we need to
+// normalize to DIPs based on the real device scale factor, not the forced one.
+TEST_F(L10nUtilWinTest, TestForcedScaling) {
+ base::CommandLine::ForCurrentProcess()->AppendSwitchASCII(
+ switches::kForceDeviceScaleFactor, "4");
+ display::Display::ResetForceDeviceScaleFactorForTesting();
+
+ NONCLIENTMETRICS_XP metrics;
+ base::win::GetNonClientMetrics(&metrics);
+ LOGFONT lf = metrics.lfMessageFont;
+
+ lf.lfHeight = 18;
robliao 2017/02/15 18:43:15 Document where 18 originated (even if it's arbitra
Bret 2017/02/15 20:43:16 Done.
+ l10n_util::AdjustUIFont(&lf);
+ EXPECT_EQ(18 / display::win::GetUnforcedDeviceScaleFactor(), lf.lfHeight);
+}
« no previous file with comments | « ui/base/l10n/l10n_util_win.cc ('k') | ui/display/win/dpi.h » ('j') | ui/display/win/screen_win.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698