Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 26955005: Remove some useless null checks in Element/NamedNodeMap (Closed)

Created:
7 years, 2 months ago by Inactive
Modified:
7 years, 2 months ago
Reviewers:
tkent, adamk, eseidel
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk
Visibility:
Public.

Description

Remove some useless null checks in Element/NamedNodeMap Make shouldIgnoreAttributeCase() a method of Element, thus avoiding unnecessary element null checks. This is based on WebKit r122767 by <akling@apple.com>;. R=tkent Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159789

Patch Set 1 #

Patch Set 2 : Move shouldIgnoreAttributeCase to Element class #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -18 lines) Patch
M Source/core/dom/Element.h View 1 2 chunks +7 lines, -0 lines 0 comments Download
M Source/core/dom/Element.cpp View 1 8 chunks +7 lines, -12 lines 0 comments Download
M Source/core/dom/NamedNodeMap.cpp View 1 2 chunks +1 line, -6 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Inactive
7 years, 2 months ago (2013-10-15 20:44:17 UTC) #1
eseidel
Meh. *this looks pretty ugly. But I guess I'm just not used to references. We're ...
7 years, 2 months ago (2013-10-15 21:09:10 UTC) #2
adamk
Yeah, I don't see much win here. The main thing that sticks out to me ...
7 years, 2 months ago (2013-10-15 21:15:52 UTC) #3
adamk
Though I guess it's a kinda sad method. Maybe I'm just sad about NamedNodeMap :)
7 years, 2 months ago (2013-10-15 21:16:47 UTC) #4
Inactive
On 2013/10/15 21:15:52, adamk wrote: > Yeah, I don't see much win here. The main ...
7 years, 2 months ago (2013-10-15 21:31:36 UTC) #5
Inactive
On 2013/10/15 21:31:36, Chris Dumez wrote: > On 2013/10/15 21:15:52, adamk wrote: > > Yeah, ...
7 years, 2 months ago (2013-10-15 21:47:18 UTC) #6
adamk
lgtm
7 years, 2 months ago (2013-10-15 21:49:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/26955005/9001
7 years, 2 months ago (2013-10-16 13:19:51 UTC) #8
commit-bot: I haz the power
7 years, 2 months ago (2013-10-16 17:39:05 UTC) #9
Message was sent while issue was closed.
Change committed as 159789

Powered by Google App Engine
This is Rietveld 408576698