Issue 26955004: Refactor part of handles.cc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 26955004: Refactor part of handles.cc (Closed)

Created:
7 years, 2 months ago by Yang

Modified:
7 years, 2 months ago

Reviewers:
rossberg

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Refactor part of handles.cc BUG= R=rossberg@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17238

Patch Set 1 #

Total comments: 1

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+43 lines, -58 lines)			Patch
M	src/compiler.cc	View	1 chunk	+27 lines, -0 lines	0 comments	Download
M	src/handles.h	View	1 chunk	+0 lines, -8 lines	0 comments	Download
M	src/handles.cc	View	1 chunk	+0 lines, -48 lines	0 comments	Download
M	src/runtime.cc	View	1 chunk	+16 lines, -2 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

rossberg

lgtm https://codereview.chromium.org/26955004/diff/1/src/runtime.cc File src/runtime.cc (right): https://codereview.chromium.org/26955004/diff/1/src/runtime.cc#newcode2968 src/runtime.cc:2968: // have been compiled into the fast construct ...

7 years, 2 months ago (2013-10-16 09:50:22 UTC) #2

Yang

7 years, 2 months ago (2013-10-16 11:52:11 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r17238 (presubmit successful).

Expand Messages | Collapse Messages