ui/gfx/vector_icons/g_search.icon - Issue 2695493002: [Mac] Touch Bar support for default browser window state

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/gfx/vector_icons/g_search.icon

Issue 2695493002: [Mac] Touch Bar support for default browser window state (Closed)

Patch Set: Fix for rsesek 3 Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 CANVAS_DIMENSIONS, 36,
	sky 2017/02/17 16:50:59 The name of this file isn't clear. What is g_searc The name of this file isn't clear. What is g_search? If this is google specific artwork, then I suspect it should be in src-internal. Evan was going to figure that out though. spqchan 2017/02/17 17:50:31 I renamed it to google_search_touchbar. This is us Show quoted text On 2017/02/17 16:50:59, sky wrote: > The name of this file isn't clear. What is g_search? If this is google specific > artwork, then I suspect it should be in src-internal. Evan was going to figure > that out though. I renamed it to google_search_touchbar. This is used for the "Search" touch bar button when the default search engine is Google sky 2017/02/17 19:25:19 Thanks for the rename, that makes it clearer. One Show quoted text On 2017/02/17 17:50:31, spqchan wrote: > On 2017/02/17 16:50:59, sky wrote: > > The name of this file isn't clear. What is g_search? If this is google > specific > > artwork, then I suspect it should be in src-internal. Evan was going to figure > > that out though. > > I renamed it to google_search_touchbar. This is used for the "Search" touch bar > button when the default search engine is Google Thanks for the rename, that makes it clearer. One more question though. Why do you need this in ui? AFAICT it's only used in chrome.
	6 PATH_COLOR_ARGB, 0xFF, 0x42, 0x85, 0xF4,

	7 MOVE_TO, 35.28f, 18.4f,

	8 R_CUBIC_TO, 0, -1.27f, -0.1f, -2.5f, -0.33f, -3.67f,

	9 H_LINE_TO, 18,

	10 R_V_LINE_TO, 6.96f,

	11 R_H_LINE_TO, 9.7f,

	12 R_CUBIC_TO, -0.43f, 2.22f, -1.7f, 4.13f, -3.6f, 5.4f,

	13 R_V_LINE_TO, 4.52f,

	14 R_H_LINE_TO, 5.8f,

	15 R_CUBIC_TO, 3.42f, -3.14f, 5.38f, -7.75f, 5.38f, -13.23f,

	16 CLOSE,

	17 NEW_PATH,

	18 PATH_COLOR_ARGB, 0xFF, 0x34, 0xA8, 0x53,

	19 MOVE_TO, 18, 36,

	20 R_CUBIC_TO, 4.86f, 0, 8.93f, -1.6f, 11.9f, -4.36f,

	21 R_LINE_TO, -5.8f, -4.52f,

	22 R_CUBIC_TO, -1.62f, 1.08f, -3.68f, 1.72f, -6.1f, 1.72f,

	23 R_CUBIC_TO, -4.7f, 0, -8.66f, -3.17f, -10.07f, -7.42f,

	24 H_LINE_TO, 1.9f,

	25 R_V_LINE_TO, 4.66f,

	26 CUBIC_TO, 4.9f, 31.98f, 10.97f, 36, 18, 36,

	27 CLOSE,

	28 NEW_PATH,

	29 PATH_COLOR_ARGB, 0xFF, 0xFB, 0xBC, 0x05,

	30 MOVE_TO, 7.93f, 21.42f,

	31 R_CUBIC_TO, -0.36f, -1.08f, -0.57f, -2.23f, -0.57f, -3.42f,

	32 R_CUBIC_TO, 0, -1.2f, 0.2f, -2.34f, 0.57f, -3.42f,

	33 V_LINE_TO, 9.92f,

	34 H_LINE_TO, 1.9f,

	35 CUBIC_TO, 0.7f, 12.35f, 0, 15.1f, 0, 18,

	36 R_CUBIC_TO, 0, 2.9f, 0.7f, 5.65f, 1.9f, 8.08f,

	37 R_LINE_TO, 6.03f, -4.66f,

	38 CLOSE,

	39 NEW_PATH,

	40 PATH_COLOR_ARGB, 0xFF, 0xEA, 0x43, 0x35,

	41 MOVE_TO, 18, 7.16f,

	42 R_CUBIC_TO, 2.64f, 0, 5.02f, 0.9f, 6.88f, 2.7f,

	43 R_LINE_TO, 5.16f, -5.17f,

	44 CUBIC_TO, 26.94f, 1.75f, 22.84f, 0, 18, 0,

	45 CUBIC_TO, 10.96f, 0, 4.88f, 4.03f, 1.9f, 9.92f,

	46 R_LINE_TO, 6.03f, 4.66f,

	47 CUBIC_TO, 9.33f, 10.32f, 13.3f, 7.16f, 18, 7.16f,

	48 CLOSE,

	49 END

OLD	NEW

« chrome/app/vector_icons/new_tab.icon ('K') | « ui/gfx/vector_icons/BUILD.gn ('k') | no next file » | no next file with comments »