Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Side by Side Diff: third_party/WebKit/Source/core/frame/UseCounter.h

Issue 2695433002: Add a UseCounter for notification permission requests from iframes (Closed)
Patch Set: rebase again Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/notifications/Notification.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google, Inc. All rights reserved. 2 * Copyright (C) 2012 Google, Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 1446 matching lines...) Expand 10 before | Expand all | Expand 10 after
1457 NotificationPermissionRequestedInsecureOrigin = 1807, 1457 NotificationPermissionRequestedInsecureOrigin = 1807,
1458 V8DeprecatedStorageInfo_QueryUsageAndQuota_Method = 1808, 1458 V8DeprecatedStorageInfo_QueryUsageAndQuota_Method = 1808,
1459 V8DeprecatedStorageInfo_RequestQuota_Method = 1809, 1459 V8DeprecatedStorageInfo_RequestQuota_Method = 1809,
1460 V8DeprecatedStorageQuota_QueryUsageAndQuota_Method = 1810, 1460 V8DeprecatedStorageQuota_QueryUsageAndQuota_Method = 1810,
1461 V8DeprecatedStorageQuota_RequestQuota_Method = 1811, 1461 V8DeprecatedStorageQuota_RequestQuota_Method = 1811,
1462 V8FileReaderSync_Constructor = 1812, 1462 V8FileReaderSync_Constructor = 1812,
1463 UncancellableTouchEventPreventDefaulted = 1813, 1463 UncancellableTouchEventPreventDefaulted = 1813,
1464 UncancellableTouchEventDueToMainThreadResponsivenessPreventDefaulted = 1814, 1464 UncancellableTouchEventDueToMainThreadResponsivenessPreventDefaulted = 1814,
1465 V8HTMLVideoElement_Poster_AttributeGetter = 1815, 1465 V8HTMLVideoElement_Poster_AttributeGetter = 1815,
1466 V8HTMLVideoElement_Poster_AttributeSetter = 1816, 1466 V8HTMLVideoElement_Poster_AttributeSetter = 1816,
1467 NotificationPermissionRequestedIframe = 1817,
1467 1468
1468 // Add new features immediately above this line. Don't change assigned 1469 // Add new features immediately above this line. Don't change assigned
1469 // numbers of any item, and don't reuse removed slots. 1470 // numbers of any item, and don't reuse removed slots.
1470 // Also, run update_use_counter_feature_enum.py in 1471 // Also, run update_use_counter_feature_enum.py in
1471 // chromium/src/tools/metrics/histograms/ to update the UMA mapping. 1472 // chromium/src/tools/metrics/histograms/ to update the UMA mapping.
1472 NumberOfFeatures, // This enum value must be last. 1473 NumberOfFeatures, // This enum value must be last.
1473 }; 1474 };
1474 1475
1475 // An interface to observe UseCounter changes. Note that this is never 1476 // An interface to observe UseCounter changes. Note that this is never
1476 // notified when the counter is disabled by |m_muteCount| or 1477 // notified when the counter is disabled by |m_muteCount| or
(...skipping 89 matching lines...) Expand 10 before | Expand all | Expand 10 after
1566 // Tracks what features/properties need to be reported to the legacy 1567 // Tracks what features/properties need to be reported to the legacy
1567 // histograms. 1568 // histograms.
1568 BitVector m_featureBits; 1569 BitVector m_featureBits;
1569 BitVector m_CSSBits; 1570 BitVector m_CSSBits;
1570 } m_legacyCounter; 1571 } m_legacyCounter;
1571 }; 1572 };
1572 1573
1573 } // namespace blink 1574 } // namespace blink
1574 1575
1575 #endif // UseCounter_h 1576 #endif // UseCounter_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/notifications/Notification.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698