tests/RecordOptsTest.cpp - Issue 269543025: Partially restore small-T optimization for very small (empty) T.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/RecordOptsTest.cpp

Issue 269543025: Partially restore small-T optimization for very small (empty) T. (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: SkTIsEmpty Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tests/RecordOptsTest.cpp

diff --git a/tests/RecordOptsTest.cpp b/tests/RecordOptsTest.cpp

index 90347eda1f5836a64b7cfa6d21bb9f2fe5e2c3df..8bce086d9cbbe6e64e088523fdb30219e45cd561 100644

--- a/tests/RecordOptsTest.cpp

+++ b/tests/RecordOptsTest.cpp

@@ -37,7 +37,6 @@ static const T* assert_type(skiatest::Reporter* r, const SkRecord& record, unsig

ReadAs<T> reader(&ptr);

record.visit(index, reader);

REPORTER_ASSERT(r, T::kType == reader.type);

- REPORTER_ASSERT(r, ptr != NULL);

return ptr;

}

« src/utils/SkTLogic.h ('K') | « src/utils/SkTLogic.h ('k') | tests/RecordPatternTest.cpp » ('j') | no next file with comments »