Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Unified Diff: content/public/common/zygote_fork_delegate_linux.h

Issue 269543014: Use RecvMsgWithPid to find real PID for zygote children (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Respond to jln feedback Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/common/zygote_fork_delegate_linux.h
diff --git a/content/public/common/zygote_fork_delegate_linux.h b/content/public/common/zygote_fork_delegate_linux.h
index 39833c5262ec7334f486fef1cfb71b9c273d5157..66f99cd13c776df9b6f0be8fe6cd54dd63dc300b 100644
--- a/content/public/common/zygote_fork_delegate_linux.h
+++ b/content/public/common/zygote_fork_delegate_linux.h
@@ -49,11 +49,11 @@ class ZygoteForkDelegate {
enum {
// Used to pass in the descriptor for talking to the Browser
kBrowserFDIndex,
- // The next two are used in the protocol for discovering the
- // child processes real PID from within the SUID sandbox. See
- // http://code.google.com/p/chromium/wiki/LinuxZygote
- kDummyFDIndex,
- kParentFDIndex,
+ // The PID oracle is used in the protocol for discovering the
+ // child process's real PID from within the SUID sandbox.
+ // The child process is required to write to the socket after
+ // successfully forking.
+ kPIDOracleFDIndex,
kNumPassedFDs // Number of FDs in the vector passed to Fork().
};

Powered by Google App Engine
This is Rietveld 408576698