Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 269543010: autofill: Convert AutofillInteractiveTest to use InfoBarManager::Observer. (Closed)

Created:
6 years, 7 months ago by tfarina
Modified:
6 years, 7 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, benquan, browser-components-watch_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org, Peter Kasting
Visibility:
Public.

Description

autofill: Convert AutofillInteractiveTest to use InfoBarManager::Observer. We are removing notifications (NotificationService API) from InfoBar code. And thus we need to migrate its uses to the Observer style. This is what this patch does. BUG=354380 TEST=browser_tests --gtest_filter=AutofillInteractiveTest.* R=isherman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267958

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -18 lines) Patch
M chrome/browser/autofill/autofill_interactive_uitest.cc View 4 chunks +14 lines, -18 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
tfarina
6 years, 7 months ago (2014-05-02 01:44:21 UTC) #1
Ilya Sherman
LGTM. Thanks, Thiago.
6 years, 7 months ago (2014-05-02 04:07:52 UTC) #2
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 7 months ago (2014-05-02 21:16:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/269543010/1
6 years, 7 months ago (2014-05-02 21:17:42 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-02 22:29:41 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel on tryserver.chromium
6 years, 7 months ago (2014-05-02 22:29:42 UTC) #6
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 7 months ago (2014-05-02 22:33:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/269543010/1
6 years, 7 months ago (2014-05-02 22:34:26 UTC) #8
commit-bot: I haz the power
6 years, 7 months ago (2014-05-02 23:20:07 UTC) #9
Message was sent while issue was closed.
Change committed as 267958

Powered by Google App Engine
This is Rietveld 408576698