Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(348)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 269543002: rebaseline_server: ignore builders we don't have any expectations for (Closed)

Created:
6 years, 7 months ago by epoger
Modified:
6 years, 7 months ago
Reviewers:
rmistry
CC:
skia-review_googlegroups.com, caryclark
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

rebaseline_server: ignore builders we don't have any expectations for (SkipBuildbotRuns) BUG=skia:2486 NOTREECHECKS=True NOTRY=True TBR=rmistry Committed: http://code.google.com/p/skia/source/detail?r=14488

Patch Set 1 #

Patch Set 2 : add comment #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -7 lines) Patch
M gm/rebaseline_server/compare_to_expectations.py View 1 1 chunk +8 lines, -1 line 0 comments Download
A + gm/rebaseline_server/testdata/inputs/gm-actuals/Test-Builder-We-Have-No-Expectations-File-For/actual-results.json View 0 chunks +-1 lines, --1 lines 0 comments Download
M gm/rebaseline_server/testdata/outputs/expected/compare_configs_test.CompareConfigsTest.test_gm/gm.json View 6 chunks +63 lines, -7 lines 1 comment Download

Messages

Total messages: 4 (0 generated)
epoger
Committing TBR to reduce sheriff pain. Ravi, PTAL. https://codereview.chromium.org/269543002/diff/20001/gm/rebaseline_server/testdata/outputs/expected/compare_configs_test.CompareConfigsTest.test_gm/gm.json File gm/rebaseline_server/testdata/outputs/expected/compare_configs_test.CompareConfigsTest.test_gm/gm.json (right): https://codereview.chromium.org/269543002/diff/20001/gm/rebaseline_server/testdata/outputs/expected/compare_configs_test.CompareConfigsTest.test_gm/gm.json#newcode147 gm/rebaseline_server/testdata/outputs/expected/compare_configs_test.CompareConfigsTest.test_gm/gm.json:147: "builder": ...
6 years, 7 months ago (2014-04-30 21:32:01 UTC) #1
epoger
The CQ bit was checked by epoger@google.com
6 years, 7 months ago (2014-04-30 21:32:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/epoger@google.com/269543002/20001
6 years, 7 months ago (2014-04-30 21:32:21 UTC) #3
commit-bot: I haz the power
6 years, 7 months ago (2014-04-30 21:32:40 UTC) #4
Message was sent while issue was closed. 
Change committed as 14488

Powered by Google App Engine
This is Rietveld 408576698