Avoid re-entrancy in DriveIntegrationService testing factory

chrome/browser/extensions/api/file_system/file_system_apitest_chromeos.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/api/file_system/file_system_api.h"
 
 #include "base/callback.h"
 #include "base/files/file_util.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/location.h"
 #include "base/macros.h"
 #include "base/path_service.h"
 #include "base/threading/thread_task_runner_handle.h"
 #include "chrome/browser/apps/app_browsertest_util.h"
 #include "chrome/browser/chromeos/drive/drive_integration_service.h"
 #include "chrome/browser/chromeos/drive/file_system_util.h"
 #include "chrome/browser/chromeos/file_manager/volume_manager.h"
 #include "chrome/browser/chromeos/login/users/fake_chrome_user_manager.h"
 #include "chrome/browser/chromeos/login/users/scoped_user_manager_enabler.h"
 #include "chrome/browser/chromeos/profiles/profile_helper.h"
 #include "chrome/browser/extensions/component_loader.h"
 #include "chrome/common/chrome_paths.h"
 #include "chrome/common/extensions/api/file_system.h"
 #include "components/drive/chromeos/file_system_interface.h"
 #include "components/drive/service/fake_drive_service.h"
 #include "content/public/test/test_utils.h"
 #include "extensions/browser/event_router.h"
+#include "google_apis/drive/base_requests.h"
 #include "google_apis/drive/drive_api_parser.h"
 #include "google_apis/drive/test_util.h"
 #include "storage/browser/fileapi/external_mount_points.h"
 #include "ui/base/ui_base_types.h"
 
 using file_manager::VolumeManager;
 
 namespace extensions {
 namespace {
 
 // Mount point names for chrome.fileSystem.requestFileSystem() tests.
 const char kWritableMountPointName[] = "writable";
 const char kReadOnlyMountPointName[] = "read-only";
 
 // Child directory created in each of the mount points.
 const char kChildDirectory[] = "child-dir";
 
 // ID of a testing extension.
 const char kTestingExtensionId[] = "pkplfbidichfdicaijlchgnapepdginl";
 
+void IgnoreDriveEntryResult(google_apis::DriveApiErrorCode error,
+                            std::unique_ptr<google_apis::FileResource> entry) {}
+
 }  // namespace
 
 // Skips the user consent dialog for chrome.fileSystem.requestFileSystem() and
 // simulates clicking of the specified dialog button.
 class ScopedSkipRequestFileSystemDialog {
  public:
   explicit ScopedSkipRequestFileSystemDialog(ui::DialogButton button) {
     file_system_api::ConsentProviderDelegate::SetAutoDialogButtonForTest(
         button);
   }
@@ skipping 38 matching lines @@
   base::Closure callback_;
   EventRouter* const event_router_;
 
   DISALLOW_COPY_AND_ASSIGN(ScopedAddListenerObserver);
 };
 
 // This class contains chrome.filesystem API test specific to Chrome OS, namely,
 // the integrated Google Drive support.
 class FileSystemApiTestForDrive : public PlatformAppBrowserTest {
  public:
-  FileSystemApiTestForDrive()
-      : fake_drive_service_(NULL),
-        integration_service_(NULL) {
-  }
+  FileSystemApiTestForDrive() {}
 
   // Sets up fake Drive service for tests (this has to be injected before the
   // real DriveIntegrationService instance is created.)
   void SetUpInProcessBrowserTestFixture() override {
     PlatformAppBrowserTest::SetUpInProcessBrowserTestFixture();
     extensions::ComponentLoader::EnableBackgroundExtensionsForTesting();
 
     ASSERT_TRUE(test_cache_root_.CreateUniqueTempDir());
 
     create_drive_integration_service_ =
@@ skipping 21 matching lines @@
   void TearDown() override {
     FileSystemChooseEntryFunction::StopSkippingPickerForTest();
     PlatformAppBrowserTest::TearDown();
   };
 
  private:
   drive::DriveIntegrationService* CreateDriveIntegrationService(
       Profile* profile) {
     // Ignore signin profile.
     if (profile->GetPath() == chromeos::ProfileHelper::GetSigninProfileDir())
-      return NULL;
+      return nullptr;
 
     // FileSystemApiTestForDrive doesn't expect that several user profiles could
     // exist simultaneously.
-    DCHECK(fake_drive_service_ == NULL);
+    DCHECK(!fake_drive_service_);
     fake_drive_service_ = new drive::FakeDriveService;
     fake_drive_service_->LoadAppListForDriveApi("drive/applist.json");
 
     SetUpTestFileHierarchy();
 
     integration_service_ = new drive::DriveIntegrationService(
-        profile, NULL, fake_drive_service_, std::string(),
-        test_cache_root_.GetPath(), NULL);
+        profile, nullptr, fake_drive_service_, std::string(),
+        test_cache_root_.GetPath(), nullptr);
     return integration_service_;
   }
 
   void SetUpTestFileHierarchy() {
     const std::string root = fake_drive_service_->GetRootResourceId();
-    ASSERT_TRUE(AddTestFile("open_existing.txt", "Can you see me?", root));
-    ASSERT_TRUE(AddTestFile("open_existing1.txt", "Can you see me?", root));
-    ASSERT_TRUE(AddTestFile("open_existing2.txt", "Can you see me?", root));
-    ASSERT_TRUE(AddTestFile("save_existing.txt", "Can you see me?", root));
-    const std::string subdir = AddTestDirectory("subdir", root);
-    ASSERT_FALSE(subdir.empty());
-    ASSERT_TRUE(AddTestFile("open_existing.txt", "Can you see me?", subdir));
+    AddTestFile("open_existing.txt", "Can you see me?", root);
+    AddTestFile("open_existing1.txt", "Can you see me?", root);
+    AddTestFile("open_existing2.txt", "Can you see me?", root);
+    AddTestFile("save_existing.txt", "Can you see me?", root);
+
+    const char kSubdirResourceId[] = "subdir_resource_id";
+    AddTestDirectory(kSubdirResourceId, "subdir", root);
+    AddTestFile("open_existing.txt", "Can you see me?", kSubdirResourceId);
   }
 
-  bool AddTestFile(const std::string& title,
+  void AddTestFile(const std::string& title,
                    const std::string& data,
                    const std::string& parent_id) {
-    std::unique_ptr<google_apis::FileResource> entry;
-    google_apis::DriveApiErrorCode error = google_apis::DRIVE_OTHER_ERROR;
-    fake_drive_service_->AddNewFile(
-        "text/plain", data, parent_id, title, false,
-        google_apis::test_util::CreateCopyResultCallback(&error, &entry));
-    content::RunAllPendingInMessageLoop();
-    return error == google_apis::HTTP_CREATED && entry;
+    fake_drive_service_->AddNewFile("text/plain", data, parent_id, title, false,
+                                    base::Bind(&IgnoreDriveEntryResult));
   }
 
-  std::string AddTestDirectory(const std::string& title,
-                               const std::string& parent_id) {
-    std::unique_ptr<google_apis::FileResource> entry;
-    google_apis::DriveApiErrorCode error = google_apis::DRIVE_OTHER_ERROR;
-    fake_drive_service_->AddNewDirectory(
-        parent_id, title, drive::AddNewDirectoryOptions(),
-        google_apis::test_util::CreateCopyResultCallback(&error, &entry));
-    content::RunAllPendingInMessageLoop();
-    return error == google_apis::HTTP_CREATED && entry ? entry->file_id() : "";
+  void AddTestDirectory(const std::string& resource_id,
+                        const std::string& title,
+                        const std::string& parent_id) {
+    fake_drive_service_->AddNewDirectoryWithResourceId(
+        resource_id, parent_id, title, drive::AddNewDirectoryOptions(),
+        base::Bind(&IgnoreDriveEntryResult));
   }
 
   base::ScopedTempDir test_cache_root_;
-  drive::FakeDriveService* fake_drive_service_;
-  drive::DriveIntegrationService* integration_service_;
+  drive::FakeDriveService* fake_drive_service_ = nullptr;
+  drive::DriveIntegrationService* integration_service_ = nullptr;
   drive::DriveIntegrationServiceFactory::FactoryCallback
       create_drive_integration_service_;
   std::unique_ptr<drive::DriveIntegrationServiceFactory::ScopedFactoryForTest>
       service_factory_for_test_;
 };
 
 // This class contains chrome.filesystem.requestFileSystem API tests.
 class FileSystemApiTestForRequestFileSystem : public PlatformAppBrowserTest {
  public:
   FileSystemApiTestForRequestFileSystem() : fake_user_manager_(nullptr) {}
@@ skipping 279 matching lines @@
       profile(), extensions::api::file_system::OnVolumeListChanged::kEventName,
       kTestingExtensionId,
       base::Bind(&FileSystemApiTestForRequestFileSystem::MountFakeVolume,
                  base::Unretained(this)));
 
   ASSERT_TRUE(RunPlatformAppTest("api_test/file_system/on_volume_list_changed"))
       << message_;
 }
 
 }  // namespace extensions