Add an integration test for edit.format.

Add an integration test for edit.format.

BUG=
R=brianwilkerson@google.com, scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/b1bc83b6d24e4f58266c3a6e10b8181ecdb819d9

[devoncarew, 2017-02-15 14:47:52]

devoncarew@google.com changed reviewers:
+ brianwilkerson@google.com, scheglov@google.com

[Brian Wilkerson, 2017-02-15 14:58:43]

lgtm

https://codereview.chromium.org/2695253002/diff/1/pkg/analysis_server/test/in...
File pkg/analysis_server/test/integration/edit/format_test.dart (right):

https://codereview.chromium.org/2695253002/diff/1/pkg/analysis_server/test/in...
pkg/analysis_server/test/integration/edit/format_test.dart:19: String
setup({bool withErrors: false}) {
Perhaps a different name so that people will know that you didn't mean "setUp".

https://codereview.chromium.org/2695253002/diff/1/pkg/analysis_server/test/in...
pkg/analysis_server/test/integration/edit/format_test.dart:62: int
initialPosition = readFile(pathname).indexOf('bar()');
The test will run faster if you capture the initial position in `setup` rather
than by reading the file.

[scheglov, 2017-02-15 15:03:53]

lgtm

[devoncarew, 2017-02-15 15:22:51]

https://codereview.chromium.org/2695253002/diff/1/pkg/analysis_server/test/in...
File pkg/analysis_server/test/integration/edit/format_test.dart (right):

https://codereview.chromium.org/2695253002/diff/1/pkg/analysis_server/test/in...
pkg/analysis_server/test/integration/edit/format_test.dart:19: String
setup({bool withErrors: false}) {
On 2017/02/15 14:58:42, Brian Wilkerson wrote:
> Perhaps a different name so that people will know that you didn't mean
"setUp".

Good point; renamed to 'formatTestSetup'.

https://codereview.chromium.org/2695253002/diff/1/pkg/analysis_server/test/in...
pkg/analysis_server/test/integration/edit/format_test.dart:62: int
initialPosition = readFile(pathname).indexOf('bar()');
On 2017/02/15 14:58:42, Brian Wilkerson wrote:
> The test will run faster if you capture the initial position in `setup` rather
> than by reading the file.

I slightly prefer this as we only have to get one value back from the
formatTestSetup() method - the file name. I/O will be pretty fast in comparison
to the integration test speed.

[devoncarew, 2017-02-15 15:23:26]

Description was changed from

==========
Add an integration test for edit.format.

BUG=
==========

to

==========
Add an integration test for edit.format.

BUG=
R=brianwilkerson@google.com, scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/b1bc83b6d24e4f58266c3a6e10b8181ecdb819d9
==========

[devoncarew, 2017-02-15 15:23:27]

Committed patchset #2 (id:20001) manually as
b1bc83b6d24e4f58266c3a6e10b8181ecdb819d9 (presubmit successful).

[Brian Wilkerson, 2017-02-15 15:27:54]

https://codereview.chromium.org/2695253002/diff/1/pkg/analysis_server/test/in...
File pkg/analysis_server/test/integration/edit/format_test.dart (right):

https://codereview.chromium.org/2695253002/diff/1/pkg/analysis_server/test/in...
pkg/analysis_server/test/integration/edit/format_test.dart:62: int
initialPosition = readFile(pathname).indexOf('bar()');
> I slightly prefer this as we only have to get one value back from the
> formatTestSetup() method - the file name.

I was thinking about assigning the value to a field, not returning it.

> I/O will be pretty fast in comparison to the integration test speed.

Our time allotment for tests is very small, so anything we can do to reduce the
time any individual test takes will reduce the number of flaky tests we have.
Also, test performance has a major impact on productivity.

[devoncarew, 2017-02-15 15:36:53]

On 2017/02/15 15:27:54, Brian Wilkerson wrote:
>
https://codereview.chromium.org/2695253002/diff/1/pkg/analysis_server/test/in...
> File pkg/analysis_server/test/integration/edit/format_test.dart (right):
> 
>
https://codereview.chromium.org/2695253002/diff/1/pkg/analysis_server/test/in...
> pkg/analysis_server/test/integration/edit/format_test.dart:62: int
> initialPosition = readFile(pathname).indexOf('bar()');
> > I slightly prefer this as we only have to get one value back from the
> > formatTestSetup() method - the file name.
> 
> I was thinking about assigning the value to a field, not returning it.
> 
> > I/O will be pretty fast in comparison to the integration test speed.
> 
> Our time allotment for tests is very small, so anything we can do to reduce
the
> time any individual test takes will reduce the number of flaky tests we have.
> Also, test performance has a major impact on productivity.

+1 to fast tests :) The integration tests times are dominated by the analysis
server startup time - that would be a good place to look to make the tests
faster.