chrome/browser/devtools/devtools_window.cc - Issue 2695233003: Fix unload controller.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/devtools/devtools_window.cc

Issue 2695233003: Fix unload controller. (Closed)

Patch Set: Fix review note. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/devtools/devtools_window.cc

diff --git a/chrome/browser/devtools/devtools_window.cc b/chrome/browser/devtools/devtools_window.cc

index a2d355ea3bc2bdb5fe9f10edec80d39e1141a8b1..e32cc60d6004ea61b57439bf9e764397de96ab94 100644

--- a/chrome/browser/devtools/devtools_window.cc

+++ b/chrome/browser/devtools/devtools_window.cc

@@ -770,7 +770,8 @@ bool DevToolsWindow::NeedsToInterceptBeforeUnload(

WebContents* contents) {

DevToolsWindow* window =

DevToolsWindow::GetInstanceForInspectedWebContents(contents);

- return window && !window->intercepted_page_beforeunload_;

+ return window && !window->intercepted_page_beforeunload_ &&

+ window->life_stage_ == kLoadCompleted;

}

// static

« no previous file with comments | « no previous file | chrome/browser/lifetime/browser_close_manager_browsertest.cc » ('j') | no next file with comments »