Fix unload controller.

chrome/browser/devtools/devtools_window.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/devtools/devtools_window.h"
 
 #include <algorithm>
 
 #include "base/command_line.h"
 #include "base/json/json_reader.h"
@@ skipping 752 matching lines @@
     window->main_web_contents_->DispatchBeforeUnload();
   }
   return true;
 }
 
 // static
 bool DevToolsWindow::NeedsToInterceptBeforeUnload(
     WebContents* contents) {
   DevToolsWindow* window =
       DevToolsWindow::GetInstanceForInspectedWebContents(contents);
-  return window && !window->intercepted_page_beforeunload_;
+  return window && !window->intercepted_page_beforeunload_ &&
+         window->life_stage_ != kClosing;

[Michael K. (Yandex Team), 2017/03/01 13:48:52]

On closing NeedsToInterceptBeforeUnload(..) shouldn't return true 'cause
InterceptPageBeforeUnload(..) isn't going to intercept beforeunload (See the
method InterceptPageBeforeUnload(..) above).

[dgozman, 2017/03/01 19:39:48]

Should we do |window->life_stage_ == kLoadCompleted| instead to match the method
above completely?

[Michael K. (Yandex Team), 2017/03/02 04:28:47]

I think you are right.
I'll make a new patchset.

 }
 
 // static
 bool DevToolsWindow::HasFiredBeforeUnloadEventForDevToolsBrowser(
     Browser* browser) {
   DCHECK(browser->is_devtools());
   // When FastUnloadController is used, devtools frontend will be detached
   // from the browser window at this point which means we've already fired
   // beforeunload.
   if (browser->tab_strip_model()->empty())
@@ skipping 625 matching lines @@
 bool DevToolsWindow::ReloadInspectedWebContents(bool bypass_cache) {
   // Only route reload via front-end if the agent is attached.
   WebContents* wc = GetInspectedWebContents();
   if (!wc || wc->GetCrashedStatus() != base::TERMINATION_STATUS_STILL_RUNNING)
     return false;
   base::FundamentalValue bypass_cache_value(bypass_cache);
   bindings_->CallClientFunction("DevToolsAPI.reloadInspectedPage",
                                 &bypass_cache_value, nullptr, nullptr);
   return true;
 }