Fix unload controller.

chrome/browser/lifetime/browser_close_manager_browsertest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/lifetime/browser_close_manager.h"
 
 #include <utility>
 #include <vector>
 
 #include "base/command_line.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/macros.h"
 #include "build/build_config.h"
 #include "chrome/browser/background/background_mode_manager.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/browser_shutdown.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/defaults.h"
 #include "chrome/browser/download/chrome_download_manager_delegate.h"
 #include "chrome/browser/download/download_prefs.h"
 #include "chrome/browser/download/download_service.h"
 #include "chrome/browser/download/download_service_factory.h"
 #include "chrome/browser/lifetime/application_lifetime.h"
 #include "chrome/browser/lifetime/keep_alive_types.h"
 #include "chrome/browser/lifetime/scoped_keep_alive.h"
 #include "chrome/browser/net/url_request_mock_util.h"
 #include "chrome/browser/prefs/session_startup_pref.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/profiles/profile_manager.h"
+#include "chrome/browser/sessions/tab_restore_service_factory.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_commands.h"
 #include "chrome/browser/ui/browser_list.h"
 #include "chrome/browser/ui/browser_window.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/url_constants.h"
 #include "chrome/test/base/in_process_browser_test.h"
 #include "chrome/test/base/ui_test_utils.h"
 #include "components/app_modal/javascript_app_modal_dialog.h"
 #include "components/app_modal/native_app_modal_dialog.h"
+#include "components/sessions/core/tab_restore_service.h"
+#include "components/sessions/core/tab_restore_service_observer.h"
 #include "content/public/browser/browser_context.h"
 #include "content/public/browser/download_item.h"
 #include "content/public/browser/download_manager.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/render_view_host.h"
 #include "content/public/browser/render_widget_host.h"
 #include "content/public/browser/web_contents.h"
+#include "content/public/test/browser_test_utils.h"
 #include "content/public/test/download_test_observer.h"
 #include "content/public/test/test_navigation_observer.h"
 #include "net/test/embedded_test_server/embedded_test_server.h"
 #include "net/test/url_request/url_request_mock_http_job.h"
 #include "net/test/url_request/url_request_slow_download_job.h"
 
 #if defined(OS_CHROMEOS)
 #include "chromeos/chromeos_switches.h"
 #endif
 
@@ skipping 48 matching lines @@
 
  private:
   int num_outstanding_;
   content::NotificationRegistrar registrar_;
   bool running_;
   base::RunLoop run_loop_;
 
   DISALLOW_COPY_AND_ASSIGN(RepeatedNotificationObserver);
 };
 
+class TabRestoreServiceChangesObserver
+    : public sessions::TabRestoreServiceObserver {
+ public:
+  explicit TabRestoreServiceChangesObserver(Profile* profile) {
+    service_ = TabRestoreServiceFactory::GetForProfile(profile);

[sky, 2017/02/16 17:16:53]

Use member initializer.

[Michael K. (Yandex Team), 2017/02/17 09:43:04]

Done.

+    if (service_)
+      service_->AddObserver(this);
+  }
+
+  ~TabRestoreServiceChangesObserver() override {
+    if (service_)
+      service_->RemoveObserver(this);
+  }
+
+  size_t GetChangesCount() const { return changes_count_; }

[sky, 2017/02/16 17:16:53]

GetChangesCount() -> changes_count()

[Michael K. (Yandex Team), 2017/02/17 09:43:04]

Done.

+
+ private:
+  void TabRestoreServiceChanged(sessions::TabRestoreService*) override {

[sky, 2017/02/16 17:16:53]

Prefix with where overrides come from, e.g.:
// sessions::TabRestoreServiceObserver:

[Michael K. (Yandex Team), 2017/02/17 09:43:04]

Done.

+    changes_count_++;
+  }
+
+  void TabRestoreServiceDestroyed(sessions::TabRestoreService*) override {
+    service_ = nullptr;
+  }
+
+  sessions::TabRestoreService* service_ = nullptr;
+  size_t changes_count_ = 0;
+
+  DISALLOW_COPY_AND_ASSIGN(TabRestoreServiceChangesObserver);
+};
+
 class TestBrowserCloseManager : public BrowserCloseManager {
  public:
   enum UserChoice {
     USER_CHOICE_USER_CANCELS_CLOSE,
     USER_CHOICE_USER_ALLOWS_CLOSE,
     NO_USER_CHOICE
   };
 
   static void AttemptClose(UserChoice user_choice) {
     scoped_refptr<BrowserCloseManager> browser_close_manager =
@@ skipping 575 matching lines @@
   ASSERT_NO_FATAL_FAILURE(AcceptClose());
   ASSERT_NO_FATAL_FAILURE(AcceptClose());
   ASSERT_NO_FATAL_FAILURE(AcceptClose());
 
   close_observer.Wait();
   EXPECT_TRUE(browser_shutdown::IsTryingToQuit());
   EXPECT_TRUE(BrowserList::GetInstance()->empty());
 }
 
 IN_PROC_BROWSER_TEST_P(BrowserCloseManagerBrowserTest,
+                       AddBeforeUnloadDuringClosing) {
+  // Currently FastUnloadController is broken :(
+  // TODO.
+  if (GetParam())
+    return;
+
+  ASSERT_TRUE(embedded_test_server()->Start());
+  ASSERT_NO_FATAL_FAILURE(ui_test_utils::NavigateToURL(
+      browser(), embedded_test_server()->GetURL("/title1.html")));
+
+  // Open second window.
+  ui_test_utils::NavigateToURLWithDisposition(
+      browser(), embedded_test_server()->GetURL("/beforeunload.html"),
+      WindowOpenDisposition::NEW_WINDOW,
+      ui_test_utils::BROWSER_TEST_WAIT_FOR_BROWSER);
+  EXPECT_EQ(2u, BrowserList::GetInstance()->size());
+  auto* browser2 = BrowserList::GetInstance()->get(0) != browser()
+                       ? BrowserList::GetInstance()->get(0)
+                       : BrowserList::GetInstance()->get(1);
+  content::WaitForLoadStop(browser2->tab_strip_model()->GetWebContentsAt(0));
+
+  // Let's work with second window only.
+  // This page has beforeunload handler already.
+  EXPECT_TRUE(browser2->tab_strip_model()
+                  ->GetWebContentsAt(0)
+                  ->NeedToFireBeforeUnload());
+  // This page doesn't have beforeunload handler. Yet.
+  ui_test_utils::NavigateToURLWithDisposition(
+      browser2, embedded_test_server()->GetURL("/title2.html"),
+      WindowOpenDisposition::NEW_FOREGROUND_TAB,
+      ui_test_utils::BROWSER_TEST_WAIT_FOR_NAVIGATION);
+  content::WaitForLoadStop(browser2->tab_strip_model()->GetWebContentsAt(1));
+  EXPECT_FALSE(browser2->tab_strip_model()
+                   ->GetWebContentsAt(1)
+                   ->NeedToFireBeforeUnload());
+  EXPECT_EQ(2, browser2->tab_strip_model()->count());
+
+  DisableHangMonitor(browser2);
+
+  // The test.
+
+  TabRestoreServiceChangesObserver restore_observer(browser2->profile());
+  content::WindowedNotificationObserver observer(
+      chrome::NOTIFICATION_BROWSER_CLOSED,
+      content::NotificationService::AllSources());
+  chrome::CloseWindow(browser2);
+  // Just to be sure CloseWindow doesn't have asynchronous tasks
+  // that could have an impact.
+  content::RunAllPendingInMessageLoop();
+
+  // Closing browser shouldn't happen because of beforeunload handler.
+  EXPECT_EQ(2u, BrowserList::GetInstance()->size());
+  // Add beforeunload handler for the 2nd (title2.html) tab which haven't had it
+  // yet.
+  ASSERT_TRUE(content::ExecuteScript(
+      browser2->tab_strip_model()->GetWebContentsAt(1)->GetRenderViewHost(),
+      "window.addEventListener('beforeunload', "
+      "function(event) { event.returnValue = 'Foo'; });"));
+  EXPECT_TRUE(browser2->tab_strip_model()
+                  ->GetWebContentsAt(1)
+                  ->NeedToFireBeforeUnload());
+  // Accept closing the first tab.
+  ASSERT_NO_FATAL_FAILURE(AcceptClose());
+  // Just to be sure accepting a dialog doesn't have asynchronous tasks
+  // that could have an impact.
+  content::RunAllPendingInMessageLoop();
+  // It shouldn't close the whole window/browser.
+  EXPECT_EQ(2u, BrowserList::GetInstance()->size());
+  EXPECT_EQ(2, browser2->tab_strip_model()->count());
+  // Accept closing the second tab.
+  ASSERT_NO_FATAL_FAILURE(AcceptClose());
+  observer.Wait();
+  // Now the second window/browser should be closed.
+  EXPECT_EQ(1u, BrowserList::GetInstance()->size());
+  EXPECT_EQ(browser(), BrowserList::GetInstance()->get(0));
+  EXPECT_EQ(1u, restore_observer.GetChangesCount());
+
+  // Restore the closed browser.
+  content::WindowedNotificationObserver open_window_observer(
+      chrome::NOTIFICATION_BROWSER_OPENED,
+      content::NotificationService::AllSources());
+  chrome::OpenWindowWithRestoredTabs(browser()->profile());
+  open_window_observer.Wait();
+  EXPECT_EQ(2u, BrowserList::GetInstance()->size());
+  browser2 = BrowserList::GetInstance()->get(0) != browser()
+                 ? BrowserList::GetInstance()->get(0)
+                 : BrowserList::GetInstance()->get(1);
+
+  // Check the restored browser contents.
+  EXPECT_EQ(2, browser2->tab_strip_model()->count());
+  EXPECT_EQ(embedded_test_server()->GetURL("/beforeunload.html"),
+            browser2->tab_strip_model()->GetWebContentsAt(0)->GetURL());
+  EXPECT_EQ(embedded_test_server()->GetURL("/title2.html"),
+            browser2->tab_strip_model()->GetWebContentsAt(1)->GetURL());
+}
+
+IN_PROC_BROWSER_TEST_P(BrowserCloseManagerBrowserTest,
                        TestCloseTabDuringShutdown) {
   ASSERT_TRUE(embedded_test_server()->Start());
   ASSERT_NO_FATAL_FAILURE(ui_test_utils::NavigateToURL(
       browsers_[0], embedded_test_server()->GetURL("/beforeunload.html")));
   DisableHangMonitor(browsers_[0]);
 
   RepeatedNotificationObserver cancel_observer(
       chrome::NOTIFICATION_BROWSER_CLOSE_CANCELLED, 1);
   chrome::CloseAllBrowsersAndQuit();
 
@@ skipping 426 matching lines @@
 
   chrome::CloseAllBrowsers();
   EXPECT_FALSE(browser_shutdown::IsTryingToQuit());
   EXPECT_TRUE(BrowserList::GetInstance()->empty());
   EXPECT_TRUE(IsBackgroundModeSuspended());
 }
 
 INSTANTIATE_TEST_CASE_P(BrowserCloseManagerWithBackgroundModeBrowserTest,
                         BrowserCloseManagerWithBackgroundModeBrowserTest,
                         testing::Bool());