Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(487)

Issue 26952002: Move speech related files out of page/ into their own directory. (Closed)

Created:
7 years, 2 months ago by eseidel
Modified:
7 years, 2 months ago
Reviewers:
eae, abarth-chromium
CC:
blink-reviews, dglazkov+blink, eae+blinkwatch, adamk+blink_chromium.org, Inactive
Visibility:
Public.

Description

Move speech related files out of page/ into their own directory. We're trying to trim down the page/ directory so we can understand the line which we're drawing between that which is moving up into the embedder/browser and that which is staying down in Blink. The concept of a "page" or "tab" will be a browser/embedder concept and Blink will only understand the contents of a single frame. This is all in preparation for out of process iframes/site isolation. R=abarth@chromium.org, eae@chromium.org BUG=305811 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159394

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -858 lines) Patch
M Source/core/core.gypi View 5 chunks +14 lines, -14 lines 0 comments Download
M Source/core/html/shadow/TextControlInnerElements.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/shadow/TextControlInnerElements.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
D Source/core/page/SpeechInput.h View 1 chunk +0 lines, -91 lines 0 comments Download
D Source/core/page/SpeechInput.cpp View 1 chunk +0 lines, -131 lines 0 comments Download
D Source/core/page/SpeechInputClient.h View 1 chunk +0 lines, -76 lines 0 comments Download
D Source/core/page/SpeechInputEvent.h View 1 chunk +0 lines, -59 lines 0 comments Download
D Source/core/page/SpeechInputEvent.cpp View 1 chunk +0 lines, -74 lines 0 comments Download
D Source/core/page/SpeechInputEvent.idl View 1 chunk +0 lines, -31 lines 0 comments Download
D Source/core/page/SpeechInputListener.h View 1 chunk +0 lines, -67 lines 0 comments Download
D Source/core/page/SpeechInputResult.h View 1 chunk +0 lines, -61 lines 0 comments Download
D Source/core/page/SpeechInputResult.cpp View 1 chunk +0 lines, -62 lines 0 comments Download
D Source/core/page/SpeechInputResult.idl View 1 chunk +0 lines, -33 lines 0 comments Download
D Source/core/page/SpeechInputResultList.h View 1 chunk +0 lines, -56 lines 0 comments Download
D Source/core/page/SpeechInputResultList.cpp View 1 chunk +0 lines, -56 lines 0 comments Download
D Source/core/page/SpeechInputResultList.idl View 1 chunk +0 lines, -33 lines 0 comments Download
A + Source/core/speech/SpeechInput.h View 2 chunks +2 lines, -3 lines 0 comments Download
A + Source/core/speech/SpeechInput.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
A + Source/core/speech/SpeechInputClient.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/core/speech/SpeechInputEvent.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/speech/SpeechInputEvent.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/speech/SpeechInputEvent.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/core/speech/SpeechInputListener.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/speech/SpeechInputResult.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/core/speech/SpeechInputResult.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/speech/SpeechInputResult.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/core/speech/SpeechInputResultList.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/speech/SpeechInputResultList.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + Source/core/speech/SpeechInputResultList.idl View 0 chunks +-1 lines, --1 lines 0 comments Download
M Source/web/SpeechInputClientImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/SpeechInputClientImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebSpeechInputResult.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
eseidel
7 years, 2 months ago (2013-10-11 00:09:49 UTC) #1
abarth-chromium
LGTM if it builds.
7 years, 2 months ago (2013-10-11 00:12:52 UTC) #2
eae
LGTM
7 years, 2 months ago (2013-10-11 00:13:27 UTC) #3
eseidel
7 years, 2 months ago (2013-10-11 00:13:55 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r159394 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698