Refactor BaseFile class to support sparse files

content/browser/download/base_file.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_DOWNLOAD_BASE_FILE_H_
 #define CONTENT_BROWSER_DOWNLOAD_BASE_FILE_H_
 
 #include <stddef.h>
 #include <stdint.h>
 
@@ skipping 15 matching lines @@
 
 namespace content {
 
 // File being downloaded and saved to disk. This is a base class
 // for DownloadFile and SaveFile, which keep more state information. BaseFile
 // considers itself the owner of the physical file and will delete it when the
 // BaseFile object is destroyed unless the ownership is revoked via a call to
 // Detach().
 class CONTENT_EXPORT BaseFile {
  public:
+  // Enum to indicate whether the file is exclusived owned, or shared among
+  // multiple writers.
+  enum AccessMode {
+    EXCLUSIVE = 0,
+    SHARED,

[asanka, 2017/02/16 18:46:26]

I'd argue that the distinction is that the file is sparse or not.

[qinmin, 2017/02/16 21:35:50]

Done. Changed this to a boolean variable is_sparse_file.

+  };
+
   // May be constructed on any thread.  All other routines (including
   // destruction) must occur on the FILE thread.
   BaseFile(const net::NetLogWithSource& net_log);
   ~BaseFile();
 
   // Returns DOWNLOAD_INTERRUPT_REASON_NONE on success, or a
   // DownloadInterruptReason on failure. Upon success, the file at |full_path()|
   // is assumed to be owned by the BaseFile. It will be deleted when the
   // BaseFile object is destroyed unless Detach() is called before destroying
   // the BaseFile instance.
   //
   // |full_path|: Full path to the download file. Can be empty, in which case
   //     the rules described in |default_directory| will be used to generate a
   //     temporary filename.
   //
   // |default_directory|: specifies the directory to create the temporary file
   //     in if |full_path| is empty. If |default_directory| and |full_path| are
   //     empty, then a temporary file will be created in the default download
   //     location as determined by ContentBrowserClient.
   //
   // |file|: The base::File handle to use. If specified, BaseFile will not open
   //     a file and will use this handle. The file should be opened for both
   //     read and write. Only makes sense if |full_path| is non-empty since it
   //     implies that the caller already knows the path to the file.  There's no
   //     perfect way to come up with a canonical path for a file. So BaseFile
   //     will not attempt to determine the |full_path|.
   //
   // |bytes_so_far|: If a file is provided (via |full_path| or |file|), then
-  //     this argument specifies the size of the file to expect. It is legal for
-  //     the file to be larger, in which case the file will be truncated down to
-  //     this size. However, if the file is shorter, then the operation will
+  //     this argument specifies the amount of data that has been written to
+  //     the file. If |access_mode| is EXCLUSIVE, this value should be the size
+  //     of the file to expect. It is legal for the file to be larger, in which
+  //     case the file will be truncated down to this size if |access_mode| is
+  //     EXCLUSIVE. However, if the file is shorter, then the operation will
   //     fail with DOWNLOAD_INTERRUPT_REASON_FILE_TOO_SHORT.
+
   //
-  // |hash_so_far|: If |bytes_so_far| is non-zero, this specifies the SHA-256
-  //     hash of the first |bytes_so_far| bytes of the target file. If
-  //     specified, BaseFile will read the first |bytes_so_far| of the target
-  //     file in order to calculate the hash and verify that the file matches.
-  //     If there's a mismatch, then the operation fails with
-  //     DOWNLOAD_INTERRUPT_REASON_FILE_HASH_MISMATCH. Not used if |hash_state|
-  //     is also specified.
+  // |hash_so_far|: If |bytes_so_far| is non-zero and |access_mode| is
+  //     EXCLUSIVE, this specifies the SHA-256 hash of the first |bytes_so_far|
+  //     bytes of the target file. If specified, BaseFile will read the first
+  //     |bytes_so_far| of the target file in order to calculate the hash and
+  //     verify that the file matches. If there's a mismatch, then the operation
+  //     fails with DOWNLOAD_INTERRUPT_REASON_FILE_HASH_MISMATCH. Not used if
+  //     |hash_state| is also specified.
   //
   // |hash_state|: The partial hash object to use. Only meaningful if there's a
   //     preexisting target file and it is non-empty (i.e. bytes_so_far is
   //     non-zero). If specified, BaseFile will assume that the bytes up to
   //     |bytes_so_far| has been accurately hashed into |hash_state| and will
-  //     ignore |hash_so_far|.
+  //     ignore |hash_so_far|. Not used if |access_mode| is SHARED.
+  //
+  // |access_mode|: Specifies whether the file is going to be accessed by
+  //     multiple writers. If so, it is possible that one writer can request
+  //     writing to an offset that is larger than the file size.
   DownloadInterruptReason Initialize(
       const base::FilePath& full_path,
       const base::FilePath& default_directory,
       base::File file,
       int64_t bytes_so_far,
       const std::string& hash_so_far,
-      std::unique_ptr<crypto::SecureHash> hash_state);
+      std::unique_ptr<crypto::SecureHash> hash_state,
+      AccessMode access_mode);
+
+  // Write a new chunk of data to the file. Returns a DownloadInterruptReason
+  // indicating the result of the operation. Works only if |access_mode| is
+  // EXCLUSIVE.
+  DownloadInterruptReason AppendDataToFile(const char* data, size_t data_len);
 
   // Write a new chunk of data to the file. Returns a DownloadInterruptReason
   // indicating the result of the operation.
-  DownloadInterruptReason AppendDataToFile(const char* data, size_t data_len);
+  DownloadInterruptReason WriteDataToFile(
+      int64_t offset,
+      const char* data,
+      size_t data_len);
 
   // Rename the download file. Returns a DownloadInterruptReason indicating the
   // result of the operation. A return code of NONE indicates that the rename
   // was successful. After a failure, the full_path() and in_progress() can be
   // used to determine the last known filename and whether the file is available
   // for writing or retrying the rename. Call Finish() to obtain the last known
   // hash state.
   DownloadInterruptReason Rename(const base::FilePath& full_path);
 
   // Mark the file as detached. Up until this method is called, BaseFile assumes
@@ skipping 27 matching lines @@
       const GURL& referrer_url);
 
   // Returns the last known path to the download file. Can be empty if there's
   // no file.
   const base::FilePath& full_path() const { return full_path_; }
 
   // Returns true if the file is open. If true, the file can be written to or
   // renamed.
   bool in_progress() const { return file_.IsValid(); }
 
-  // Returns the number of bytes in the file pointed to by full_path().
+  // Returns the number of bytes that has been written so far. If |access_mode_|
+  // is EXCLUSIVE, this should always be equal to the file size. If
+  // |access_mode_| is SHARED, this should not be larger than the file size
+  // as the file may contain holes in it.
   int64_t bytes_so_far() const { return bytes_so_far_; }
 
   std::string DebugString() const;
 
  private:
   friend class BaseFileTest;
   FRIEND_TEST_ALL_PREFIXES(BaseFileTest, IsEmptyHash);
 
   // Creates and opens the file_ if it is invalid.
   //
-  // If |hash_so_far| is not empty, then it must match the SHA-256 hash of the
-  // first |bytes_so_far_| bytes of |file_|. If there's a hash mismatch, Open()
-  // fails with DOWNLOAD_INTERRUPT_REASON_FILE_HASH_MISMATCH.
+  // If |access_mode_| is EXCLUSIVE and |hash_so_far| is not empty, then it must
+  // match the SHA-256 hash of the first |bytes_so_far_| bytes of |file_|. If
+  // there's a hash mismatch, Open() fails with
+  // DOWNLOAD_INTERRUPT_REASON_FILE_HASH_MISMATCH.
   //
   // If the opened file is shorter than |bytes_so_far_| bytes, then Open() fails
-  // with DOWNLOAD_INTERRUPT_REASON_FILE_TOO_SHORT. If the opened file is
-  // longer, then the file is truncated to |bytes_so_far_|.
+  // with DOWNLOAD_INTERRUPT_REASON_FILE_TOO_SHORT. If the opened file is longer
+  // and |access_mode_| is EXCLUSIVE, then the file is truncated to
+  // |bytes_so_far_|.
   //
   // Open() can fail for other reasons as well. In that case, it returns a
   // relevant interrupt reason. Unless Open() return
   // DOWNLOAD_INTERRUPT_REASON_NONE, it should be assumed that |file_| is not
   // valid.
   DownloadInterruptReason Open(const std::string& hash_so_far);
 
   // Closes and resets file_.
   void Close();
 
   // Resets file_.
   void ClearFile();
 
+  // Writes data at the current position.
+  DownloadInterruptReason WriteAtCurrentPos(const char* data, size_t data_len);
+
   // Platform specific method that moves a file to a new path and adjusts the
   // security descriptor / permissions on the file to match the defaults for the
   // new directory.
   DownloadInterruptReason MoveFileAndAdjustPermissions(
       const base::FilePath& new_path);
 
   // Split out from CurrentSpeed to enable testing.
   int64_t CurrentSpeedAtTime(base::TimeTicks current_time) const;
 
-  // Verifies that:
+  // This function is only useful when |access_mode_| is EXCLUSIVE. It verifies

[asanka, 2017/02/16 18:46:26]

Once the download is complete, we'd still need use this to calculate the hash of
the entire file. Otherwise we'll break SafeBrowsing.

[qinmin, 2017/02/16 21:35:50]

Added the code to calculate the hash when finish() is called.

+  // that:
   // * Size of the file represented by |file_| is at least |bytes_so_far_|.
   //
   // * If |hash_to_expect| is not empty, then the result of hashing the first
   //   |bytes_so_far_| bytes of |file_| matches |hash_to_expect|.
   //
   // If the result is REASON_NONE, then on return |secure_hash_| is valid and
   // is ready to hash bytes from offset |bytes_so_far_| + 1.
   DownloadInterruptReason CalculatePartialHash(
       const std::string& hash_to_expect);
 
@@ skipping 24 matching lines @@
   // Used to calculate hash for the file when calculate_hash_ is set.
   std::unique_ptr<crypto::SecureHash> secure_hash_;
 
   // Start time for calculating speed.
   base::TimeTicks start_tick_;
 
   // Indicates that this class no longer owns the associated file, and so
   // won't delete it on destruction.
   bool detached_ = false;
 
+  AccessMode access_mode_ = EXCLUSIVE;
+
   net::NetLogWithSource net_log_;
 
   DISALLOW_COPY_AND_ASSIGN(BaseFile);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_DOWNLOAD_BASE_FILE_H_