Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7947)

Unified Diff: chrome/browser/ui/webui/password_manager_internals/password_manager_internals_ui.h

Issue 269513003: Password manager internals page service: wiring it in (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Adding forgotten s/NotifyCanUseLogRouter/OnLogRouterAvailabilityChanged in tests Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/password_manager_internals/password_manager_internals_ui.h
diff --git a/chrome/browser/ui/webui/password_manager_internals/password_manager_internals_ui.h b/chrome/browser/ui/webui/password_manager_internals/password_manager_internals_ui.h
index c73486a6756e2958d9f8bb858ee09eec01925502..32653014a3e6e327a57c9069d8df596f5e7854b6 100644
--- a/chrome/browser/ui/webui/password_manager_internals/password_manager_internals_ui.h
+++ b/chrome/browser/ui/webui/password_manager_internals/password_manager_internals_ui.h
@@ -25,30 +25,9 @@ class PasswordManagerInternalsUI
virtual void LogSavePasswordProgress(const std::string& text) OVERRIDE;
private:
- // These types describe which kinds of notifications
- // PasswordManagerInternalsUI can send to PasswordManagerClient.
- enum ClientNotificationType {
- PAGE_OPENED, // Send when the page gets opened.
- PAGE_CLOSED // Send when the page gets closed.
- };
-
- // This acts on all PasswordManagerClient instances of the current profile
- // based on |notification_type|:
- // PAGE_OPENED -- |this| is set as clients' PasswordManagerLogger
- // PAGE_CLOSED -- PasswordManagerLogger is reset for clients
- void NotifyAllPasswordManagerClients(
- ClientNotificationType notification_type);
-
- // Helper used by LogSavePasswordProgress, actually sends |text| to the
- // internals page.
- void LogInternal(const std::string& text);
-
- // Whether the observed WebContents did stop loading.
- bool did_stop_loading_;
-
- // Stores the logs here until |did_stop_loading_| becomes true. At that point
- // all stored logs are displayed and any new are displayed directly.
- std::string log_buffer_;
+ // Whether |this| registered as a log receiver with the
+ // PasswordManagerInternalsService.
+ bool registered_with_logging_service_;
DISALLOW_COPY_AND_ASSIGN(PasswordManagerInternalsUI);
};

Powered by Google App Engine
This is Rietveld 408576698