Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4908)

Unified Diff: chrome/browser/password_manager/chrome_password_manager_client.h

Issue 269513003: Password manager internals page service: wiring it in (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Adding forgotten s/NotifyCanUseLogRouter/OnLogRouterAvailabilityChanged in tests Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/password_manager/chrome_password_manager_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/password_manager/chrome_password_manager_client.h
diff --git a/chrome/browser/password_manager/chrome_password_manager_client.h b/chrome/browser/password_manager/chrome_password_manager_client.h
index f57fc3b5652ae426c7f119945ea7a18b700c5dc7..4fad5077c0a401bbc9d89a628de1266d5339e126 100644
--- a/chrome/browser/password_manager/chrome_password_manager_client.h
+++ b/chrome/browser/password_manager/chrome_password_manager_client.h
@@ -53,8 +53,7 @@ class ChromePasswordManagerClient
virtual base::FieldTrial::Probability GetProbabilityForExperiment(
const std::string& experiment_name) OVERRIDE;
virtual bool IsPasswordSyncEnabled() OVERRIDE;
- virtual void SetLogger(password_manager::PasswordManagerLogger* logger)
- OVERRIDE;
+ virtual void OnLogRouterAvailabilityChanged(bool router_can_be_used) OVERRIDE;
virtual void LogSavePasswordProgress(const std::string& text) OVERRIDE;
virtual bool IsLoggingActive() const OVERRIDE;
@@ -107,7 +106,7 @@ class ChromePasswordManagerClient
void ShowPasswordEditingPopup(
const gfx::RectF& bounds, const autofill::PasswordForm& form);
- Profile* GetProfile();
+ Profile* const profile_;
password_manager::ContentPasswordManagerDriver driver_;
@@ -121,10 +120,8 @@ class ChromePasswordManagerClient
// Allows authentication callbacks to be destroyed when this client is gone.
base::WeakPtrFactory<ChromePasswordManagerClient> weak_factory_;
- // Points to an active logger instance to use for, e.g., reporting progress on
- // saving passwords. If there is no active logger (most of the time), the
- // pointer will be NULL.
- password_manager::PasswordManagerLogger* logger_;
+ // True if |this| is registered with some LogRouter which can accept logs.
+ bool can_use_log_router_;
DISALLOW_COPY_AND_ASSIGN(ChromePasswordManagerClient);
};
« no previous file with comments | « no previous file | chrome/browser/password_manager/chrome_password_manager_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698