Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/version_ui/resources/about_version.js

Issue 2695123007: CrOS: Add firmware version to about://version (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/version_ui/resources/about_version.html ('k') | components/version_ui/version_ui_constants.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/version_ui/resources/about_version.js
diff --git a/components/version_ui/resources/about_version.js b/components/version_ui/resources/about_version.js
index 8232edd39f4f18c94ddcec306146dc0870f119bc..0b792d7b3aa98337b5ff3f2b827377b636c18286 100644
--- a/components/version_ui/resources/about_version.js
+++ b/components/version_ui/resources/about_version.js
@@ -41,6 +41,14 @@ function returnOsVersion(osVersion) {
}
/**
+ * Callback from the backend with the Firmware version to display.
michaelpg 2017/02/16 04:20:31 nit: lowercase firmware
stevenjb 2017/02/16 18:24:25 Done.
+ * @param {string} firmwareVersion
+ */
+function returnOsFirmwareVersion(firmwareVersion) {
+ $('firmware_version').textContent = firmwareVersion;
+}
+
+/**
* Callback from the backend with the ARC version to display.
* @param {string} arcVersion The ARC version to display.
*/
« no previous file with comments | « components/version_ui/resources/about_version.html ('k') | components/version_ui/version_ui_constants.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698