CrOS: Add firmware version to about://version

components/version_ui/resources/about_version.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * Callback from the backend with the list of variations to display.
  * This call will build the variations section of the version page, or hide that
  * section if there are none to display.
  * @param {!Array<string>} variationsList The list of variations.
  */
@@ skipping 23 matching lines @@
 
 /**
  * Callback from the backend with the OS version to display.
  * @param {string} osVersion The OS version to display.
  */
 function returnOsVersion(osVersion) {
   $('os_version').textContent = osVersion;
 }
 
 /**
+ * Callback from the backend with the firmware version to display.
+ * @param {string} firmwareVersion

[achuithb, 2017/02/16 20:08:36]

the firmware version to display.

[stevenjb, 2017/02/16 20:26:53]

I didn't mess with the other comments, but we've been moving towards more
succinct comments; the return value is already well described by the name and
the function comment.

+ */
+function returnOsFirmwareVersion(firmwareVersion) {
+  $('firmware_version').textContent = firmwareVersion;
+}
+
+/**
  * Callback from the backend with the ARC version to display.
  * @param {string} arcVersion The ARC version to display.
  */
 function returnARCVersion(arcVersion) {
   $('arc_version').textContent = arcVersion;
   $('arc_holder').hidden = !arcVersion;
 }
 
 /**
  * Callback from chromeosInfoPrivate with the value of the customization ID.
  * @param {!{customizationId: string}} response
  */
 function returnCustomizationId(response) {
   if (!response.customizationId)
     return;
   $('customization_id_holder').hidden = false;
   $('customization_id').textContent = response.customizationId;
 }
 
 /* All the work we do onload. */
 function onLoadWork() {
   chrome.send('requestVersionInfo');
   if (cr.isChromeOS) {
     $('arc_holder').hidden = true;
     chrome.chromeosInfoPrivate.get(['customizationId'], returnCustomizationId);
   }
 }
 
 document.addEventListener('DOMContentLoaded', onLoadWork);