Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Unified Diff: third_party/WebKit/Source/devtools/front_end/common/StaticContentProvider.js

Issue 2695123004: DevTools: Only provide static script content to UISourceCode (Closed)
Patch Set: Now there is less Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/common/StaticContentProvider.js
diff --git a/third_party/WebKit/Source/devtools/front_end/common/StaticContentProvider.js b/third_party/WebKit/Source/devtools/front_end/common/StaticContentProvider.js
index 7403bb85738b3f922c819a190c04c41a41c91b62..d7df1c8b3f37e99fd88c0c8e38601ecd7bcdd8f0 100644
--- a/third_party/WebKit/Source/devtools/front_end/common/StaticContentProvider.js
+++ b/third_party/WebKit/Source/devtools/front_end/common/StaticContentProvider.js
@@ -9,7 +9,7 @@ Common.StaticContentProvider = class {
/**
* @param {string} contentURL
* @param {!Common.ResourceType} contentType
- * @param {function():!Promise<string>} lazyContent
+ * @param {function():!Promise<?string>} lazyContent
*/
constructor(contentURL, contentType, lazyContent) {
this._contentURL = contentURL;
@@ -49,7 +49,7 @@ Common.StaticContentProvider = class {
* @return {!Promise<?string>}
*/
requestContent() {
- return /** @type {!Promise<?string>} */ (this._lazyContent());
+ return this._lazyContent();
}
/**
@@ -61,10 +61,10 @@ Common.StaticContentProvider = class {
*/
searchInContent(query, caseSensitive, isRegex, callback) {
/**
- * @param {string} content
+ * @param {?string} content
*/
function performSearch(content) {
- callback(Common.ContentProvider.performSearchInContent(content, query, caseSensitive, isRegex));
+ callback(Common.ContentProvider.performSearchInContent(content || '', query, caseSensitive, isRegex));
}
this._lazyContent().then(performSearch);

Powered by Google App Engine
This is Rietveld 408576698