third_party/WebKit/LayoutTests/webaudio/StereoPanner/stereopannernode-no-glitch.html - Issue 2695113003: Convert StereoPanner Audit tests to testharness

Unified Diff: third_party/WebKit/LayoutTests/webaudio/StereoPanner/stereopannernode-no-glitch.html

Issue 2695113003: Convert StereoPanner Audit tests to testharness (Closed)

Patch Set: Address review comments Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

« no previous file with comments | « third_party/WebKit/LayoutTests/webaudio/StereoPanner/stereopannernode-basic-expected.txt ('k') | third_party/WebKit/LayoutTests/webaudio/StereoPanner/stereopannernode-no-glitch-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/webaudio/StereoPanner/stereopannernode-no-glitch.html

diff --git a/third_party/WebKit/LayoutTests/webaudio/StereoPanner/stereopannernode-no-glitch.html b/third_party/WebKit/LayoutTests/webaudio/StereoPanner/stereopannernode-no-glitch.html

index 65947be045807f25fdcffedd80352d23afaebd41..e9517cca9d5e631cbf135e29fe3bc45181c2a8b0 100644

--- a/third_party/WebKit/LayoutTests/webaudio/StereoPanner/stereopannernode-no-glitch.html

+++ b/third_party/WebKit/LayoutTests/webaudio/StereoPanner/stereopannernode-no-glitch.html

@@ -2,16 +2,14 @@

<html>

<head>

- <script src="../../resources/js-test.js"></script>

+ <script src="../../resources/testharness.js"></script>

+ <script src="../../resources/testharnessreport.js"></script>

</head>

<body>

- description('Test if StereoPannerNode producing glitches by crossing zero.');

- window.jsTestIsAsync = true;

var sampleRate = 44100;

var renderDuration = 0.5;

@@ -42,7 +40,9 @@

// samples are identical, the transition has not started.

while (chanL[index-1] === chanL[index] || chanR[index-1] === chanR[index]) {

if (++index >= input.length) {

- testFailed('No transition found in the channel data.');

+ // TODO(rtoy): Replace this

hongchan 2017/02/21 17:11:36 If this is replaced as you wanted, please remove t

Raymond Toy 2017/02/21 17:41:54 Done.

+ Should(false, Transition in the channel data')

+ .summarize('found', 'not found');

return null;

}

@@ -52,13 +52,16 @@

// the transition is still ongoing.

while (chanL[index-1] !== chanL[index] || chanR[index-1] !== chanR[index]) {

if (++index >= input.length) {

- testFailed('A transition found but the buffer ended prematurely.');

+ Should(false, 'Transition found')

+ .summarize('', 'but the buffer ended prematurely');

return null;

}

end = index;

- testPassed('Transition found between sample #' + start + ' and #' + end + '.');

+ Should('Transition found between sample #' + start + ' and #' + end,

+ true)

+ .summarize('correctly', 'incorrectly');

return {

left: chanL.subarray(start, end),

@@ -171,7 +174,6 @@

audit.defineTask('finish-test', function (done) {

done();

- finishJSTest();

});

audit.runTasks(

@@ -179,8 +181,6 @@

'positive-to-negative',

'finish-test'

);

- successfullyParsed = true;

</script>

</body>