Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Unified Diff: commit-queue/pending_manager.py

Issue 26951002: CQ: handle more HTTP-related errors (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: commit-queue/pending_manager.py
===================================================================
--- commit-queue/pending_manager.py (revision 228497)
+++ commit-queue/pending_manager.py (working copy)
@@ -218,8 +218,17 @@
"""Returns the list of issue number for reviews on Rietveld with their last
patchset with commit+ flag set.
"""
- return self.context.rietveld.get_pending_issues()
+ try:
+ return self.context.rietveld.get_pending_issues()
+ except urllib2.URLError as e:
+ if 'timed out' in e.reason:
+ # Handle timeouts gracefully. Log them and pretend there are no
+ # pending issues. We'll retry on the next iteration.
+ logging.warn('request to fetch pending issues timed out: %s' % e)
+ return []
+ raise
+
def process_new_pending_commit(self):
"""Starts verification on newly found pending commits."""
expected = set(i.name for i in self.all_verifiers)
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698