third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.h - Issue 2695093007: [Typed CSSOM] Get computed values for custom properties

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.h

Issue 2695093007: [Typed CSSOM] Get computed values for custom properties

Patch Set: Fix unregistered props and registered but unset props Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/typedcssom/computedstyle/resources/1x1-green.png ('k') | third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.h

diff --git a/third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.h b/third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.h

index 62334aa709cb7f1984ed7be89597a8d4fbb37484..d3ef0fd65b2017788d579236718f533e8ae707f9 100644

--- a/third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.h

+++ b/third_party/WebKit/Source/core/css/cssom/ComputedStylePropertyMap.h

@@ -39,6 +39,7 @@ class CORE_EXPORT ComputedStylePropertyMap : public ImmutableStylePropertyMap {

private:

Node* node() const;

+ const ComputedStyle* updateStyle() const;

protected:

ComputedStylePropertyMap(Node* node, const String& pseudoElement = String())

@@ -49,7 +50,8 @@ class CORE_EXPORT ComputedStylePropertyMap : public ImmutableStylePropertyMap {

m_node(node) {}

CSSStyleValueVector getAllInternal(CSSPropertyID) override;

- CSSStyleValueVector getAllInternal(AtomicString customPropertyName) override;

+ CSSStyleValueVector getAllInternal(AtomicString customPropertyName,

+ ExceptionState&) override;

HeapVector<StylePropertyMapEntry> getIterationEntries() override {

return HeapVector<StylePropertyMapEntry>();