Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1684)

Unified Diff: content/browser/renderer_host/render_widget_host_view_mac.mm

Issue 2695093005: Remove RWHV::SetBounds() from the public API, and make comments clearer.
Patch Set: Revert web_contents_sizer to its previous shenanigans (http://crbug.com/693953). Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_mac.mm
diff --git a/content/browser/renderer_host/render_widget_host_view_mac.mm b/content/browser/renderer_host/render_widget_host_view_mac.mm
index f2c270f4e98538aa89fa4d6c538509d511e509ab..01636a24c55fc2a9d96316c105f07ffe74156e7a 100644
--- a/content/browser/renderer_host/render_widget_host_view_mac.mm
+++ b/content/browser/renderer_host/render_widget_host_view_mac.mm
@@ -801,12 +801,15 @@ new BrowserCompositorMac(this, this, render_widget_host_->is_hidden(),
void RenderWidgetHostViewMac::SetSize(const gfx::Size& size) {
gfx::Rect rect = GetViewBounds();
rect.set_size(size);
- SetBounds(rect);
+ RequestTopLevelBoundsInScreen(rect);
}
-void RenderWidgetHostViewMac::SetBounds(const gfx::Rect& rect) {
- // |rect.size()| is view coordinates, |rect.origin| is screen coordinates,
- // TODO(thakis): fix, http://crbug.com/73362
+void RenderWidgetHostViewMac::RequestTopLevelBoundsInScreen(
+ const gfx::Rect& rect) {
+ // TODO(miu): Fix: Some callers pass-in |rect.size()| as view coordinates,
+ // but the interface requires |rect| to be in screen coordinates.
+ // http://crbug.com/73362
+
if (render_widget_host_->is_hidden())
return;
« no previous file with comments | « content/browser/renderer_host/render_widget_host_view_mac.h ('k') | content/public/browser/render_widget_host_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698