Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Unified Diff: content/browser/renderer_host/render_widget_host_view_aura.cc

Issue 2695093005: Remove RWHV::SetBounds() from the public API, and make comments clearer.
Patch Set: Revert web_contents_sizer to its previous shenanigans (http://crbug.com/693953). Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_aura.cc
diff --git a/content/browser/renderer_host/render_widget_host_view_aura.cc b/content/browser/renderer_host/render_widget_host_view_aura.cc
index 74e7ed4b131dd896ab1751c3234c0bc76dedbf7d..b0cfd5c3931b9abcb77fb7dea33b590e1c025742 100644
--- a/content/browser/renderer_host/render_widget_host_view_aura.cc
+++ b/content/browser/renderer_host/render_widget_host_view_aura.cc
@@ -482,7 +482,7 @@ void RenderWidgetHostViewAura::InitAsPopup(
aura::Window* root = popup_parent_host_view_->window_->GetRootWindow();
aura::client::ParentWindowWithContext(window_, root, bounds_in_screen);
- SetBounds(bounds_in_screen);
+ RequestTopLevelBoundsInScreen(bounds_in_screen);
Show();
if (NeedsMouseCapture())
window_->SetCapture();
@@ -596,7 +596,8 @@ void RenderWidgetHostViewAura::SetSize(const gfx::Size& size) {
InternalSetBounds(gfx::Rect(window_->bounds().origin(), size));
}
-void RenderWidgetHostViewAura::SetBounds(const gfx::Rect& rect) {
+void RenderWidgetHostViewAura::RequestTopLevelBoundsInScreen(
+ const gfx::Rect& rect) {
display::Display display =
popup_parent_host_view_
? display::Screen::GetScreen()->GetDisplayNearestWindow(

Powered by Google App Engine
This is Rietveld 408576698