content/browser/media/capture/web_contents_video_capture_device_unittest.cc - Issue 2695093005: Remove RWHV::SetBounds() from the public API, and make comments clearer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/media/capture/web_contents_video_capture_device_unittest.cc

Issue 2695093005: Remove RWHV::SetBounds() from the public API, and make comments clearer.

Patch Set: Revert web_contents_sizer to its previous shenanigans (http://crbug.com/693953). Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/frame_host/render_widget_host_view_guest.cc ('k') | content/browser/renderer_host/render_widget_host_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/media/capture/web_contents_video_capture_device_unittest.cc

diff --git a/content/browser/media/capture/web_contents_video_capture_device_unittest.cc b/content/browser/media/capture/web_contents_video_capture_device_unittest.cc

index ca48ca4041122e033b3f03930ec48be51ded70ab..46ef608f4f5aa4defea37a606d4f8f26b7f6aa24 100644

--- a/content/browser/media/capture/web_contents_video_capture_device_unittest.cc

+++ b/content/browser/media/capture/web_contents_video_capture_device_unittest.cc

@@ -117,10 +117,10 @@ class CaptureTestView : public TestRenderWidgetHostView {

}

void SetSize(const gfx::Size& size) override {

- SetBounds(gfx::Rect(fake_bounds_.origin(), size));

+ RequestTopLevelBoundsInScreen(gfx::Rect(fake_bounds_.origin(), size));

}

- void SetBounds(const gfx::Rect& rect) override {

+ void RequestTopLevelBoundsInScreen(const gfx::Rect& rect) override {

fake_bounds_ = rect;

}