chrome/browser/ui/web_contents_sizer.mm - Issue 2695093005: Remove RWHV::SetBounds() from the public API, and make comments clearer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/web_contents_sizer.mm

Issue 2695093005: Remove RWHV::SetBounds() from the public API, and make comments clearer.

Patch Set: Resolve Android compile issue (missed one rename). Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/web_contents_sizer.mm

diff --git a/chrome/browser/ui/web_contents_sizer.mm b/chrome/browser/ui/web_contents_sizer.mm

index bdb78960da21d6fdfbe00ae6d7abc452dcfbcb92..fc0d5fdec1c861056c0dd951d0fc0e27b4fd1dee 100644

--- a/chrome/browser/ui/web_contents_sizer.mm

+++ b/chrome/browser/ui/web_contents_sizer.mm

@@ -10,6 +10,9 @@

void ResizeWebContents(content::WebContents* web_contents,

const gfx::Rect& new_bounds) {

+ // TODO(miu): This is a layering violation, since only the RWHV should know

+ // whether the resize operation is valid and, if so, execute it.

+ // http://crbug.com/73362

NSView* view = web_contents->GetNativeView();

NSRect old_wcv_frame = [view frame];

CGFloat new_x = old_wcv_frame.origin.x;