Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Side by Side Diff: content/browser/renderer_host/render_widget_host_view_base.h

Issue 2695093005: Remove RWHV::SetBounds() from the public API, and make comments clearer.
Patch Set: Revert web_contents_sizer to its previous shenanigans (http://crbug.com/693953). Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_BASE_H_ 5 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_BASE_H_
6 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_BASE_H_ 6 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_BASE_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 141 matching lines...) Expand 10 before | Expand all | Expand 10 after
152 size_t offset, 152 size_t offset,
153 const gfx::Range& range); 153 const gfx::Range& range);
154 154
155 // The requested size of the renderer. May differ from GetViewBounds().size() 155 // The requested size of the renderer. May differ from GetViewBounds().size()
156 // when the view requires additional throttling. 156 // when the view requires additional throttling.
157 virtual gfx::Size GetRequestedRendererSize() const; 157 virtual gfx::Size GetRequestedRendererSize() const;
158 158
159 // The size of the view's backing surface in non-DPI-adjusted pixels. 159 // The size of the view's backing surface in non-DPI-adjusted pixels.
160 virtual gfx::Size GetPhysicalBackingSize() const; 160 virtual gfx::Size GetPhysicalBackingSize() const;
161 161
162 // Requests that the View's top-level window move itself to the specified
163 // position and size on-screen (in screen coordinates). This is used for
164 // pop-ups and some types of fullscreen Views. The default implementation is a
165 // no-op.
166 virtual void RequestTopLevelBoundsInScreen(const gfx::Rect& rect);
167
162 // Whether or not Blink's viewport size should be shrunk by the height of the 168 // Whether or not Blink's viewport size should be shrunk by the height of the
163 // URL-bar. 169 // URL-bar.
164 virtual bool DoBrowserControlsShrinkBlinkSize() const; 170 virtual bool DoBrowserControlsShrinkBlinkSize() const;
165 171
166 // The height of the URL-bar browser controls. 172 // The height of the URL-bar browser controls.
167 virtual float GetTopControlsHeight() const; 173 virtual float GetTopControlsHeight() const;
168 174
169 // The height of the bottom bar. 175 // The height of the bottom bar.
170 virtual float GetBottomControlsHeight() const; 176 virtual float GetBottomControlsHeight() const;
171 177
(...skipping 311 matching lines...) Expand 10 before | Expand all | Expand 10 after
483 base::ObserverList<RenderWidgetHostViewBaseObserver> observers_; 489 base::ObserverList<RenderWidgetHostViewBaseObserver> observers_;
484 490
485 base::WeakPtrFactory<RenderWidgetHostViewBase> weak_factory_; 491 base::WeakPtrFactory<RenderWidgetHostViewBase> weak_factory_;
486 492
487 DISALLOW_COPY_AND_ASSIGN(RenderWidgetHostViewBase); 493 DISALLOW_COPY_AND_ASSIGN(RenderWidgetHostViewBase);
488 }; 494 };
489 495
490 } // namespace content 496 } // namespace content
491 497
492 #endif // CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_BASE_H_ 498 #endif // CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_BASE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698