Remove RWHV::SetBounds() from the public API, and make comments clearer.

content/browser/renderer_host/render_widget_host_view_aura_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/render_widget_host_view_aura.h"
 
 #include <stddef.h>
 #include <stdint.h>
 
 #include <tuple>
@@ skipping 810 matching lines @@
     ui::GestureConfiguration::GetInstance()->set_scroll_debounce_interval_in_ms(
         debounce_interval_in_ms);
 
     RenderWidgetHostViewAuraTest::SetUp();
 
     view_->SetOverscrollControllerEnabled(true);
     overscroll_delegate_.reset(new TestOverscrollDelegate(view_));
     view_->overscroll_controller()->set_delegate(overscroll_delegate_.get());
 
     view_->InitAsChild(nullptr);
-    view_->SetBounds(gfx::Rect(0, 0, 400, 200));
+    view_->RequestTopLevelBoundsInScreen(gfx::Rect(0, 0, 400, 200));
     view_->Show();
 
     sink_->ClearMessages();
   }
 
   // TODO(jdduke): Simulate ui::Events, injecting through the view.
   void SimulateMouseEvent(WebInputEvent::Type type) {
     widget_host_->ForwardMouseEvent(SyntheticWebMouseEventBuilder::Build(type));
   }
 
@@ skipping 186 matching lines @@
   EXPECT_TRUE(view_->ShouldActivate());
 }
 
 // Checks that a popup is positioned correctly relative to its parent using
 // screen coordinates.
 TEST_F(RenderWidgetHostViewAuraTest, PositionChildPopup) {
 
   aura::Window* window = parent_view_->GetNativeView();
   aura::Window* root = window->GetRootWindow();
 
-  parent_view_->SetBounds(gfx::Rect(10, 10, 800, 600));
+  parent_view_->RequestTopLevelBoundsInScreen(gfx::Rect(10, 10, 800, 600));
   gfx::Rect bounds_in_screen = parent_view_->GetViewBounds();
   int horiz = bounds_in_screen.width() / 4;
   int vert = bounds_in_screen.height() / 4;
   bounds_in_screen.Inset(horiz, vert);
 
   // Verify that when the popup is initialized for the first time, it correctly
   // treats the input bounds as screen coordinates.
   view_->InitAsPopup(parent_view_, bounds_in_screen);
 
   gfx::Rect final_bounds_in_screen = view_->GetViewBounds();
   EXPECT_EQ(final_bounds_in_screen.ToString(), bounds_in_screen.ToString());
 
-  // Verify that directly setting the bounds via SetBounds() treats the input
-  // as screen coordinates.
+  // Verify that directly setting the bounds via RequestTopLevelBoundsInScreen()
+  // treats the input as screen coordinates.
   bounds_in_screen = gfx::Rect(60, 60, 100, 100);
-  view_->SetBounds(bounds_in_screen);
+  view_->RequestTopLevelBoundsInScreen(bounds_in_screen);
   final_bounds_in_screen = view_->GetViewBounds();
   EXPECT_EQ(final_bounds_in_screen.ToString(), bounds_in_screen.ToString());
 
   // Verify that setting the size does not alter the origin.
   gfx::Point original_origin = window->bounds().origin();
   view_->SetSize(gfx::Size(120, 120));
   gfx::Point new_origin = window->bounds().origin();
   EXPECT_EQ(original_origin.ToString(), new_origin.ToString());
 
   aura::client::SetScreenPositionClient(root, nullptr);
@@ skipping 13 matching lines @@
   parent2->Init(ui::LAYER_TEXTURED);
   parent2->Show();
 
   root->AddChild(parent1.get());
   parent1->AddChild(parent2.get());
   parent2->AddChild(view_->GetNativeView());
 
   root->SetBounds(gfx::Rect(0, 0, 800, 600));
   parent1->SetBounds(gfx::Rect(1, 1, 300, 300));
   parent2->SetBounds(gfx::Rect(2, 2, 200, 200));
-  view_->SetBounds(gfx::Rect(3, 3, 100, 100));
+  view_->RequestTopLevelBoundsInScreen(gfx::Rect(3, 3, 100, 100));
   // view_ will be destroyed when parent is destroyed.
   view_ = nullptr;
 
   // Flush the state after initial setup is done.
   widget_host_->OnMessageReceived(
       ViewHostMsg_UpdateScreenRects_ACK(widget_host_->GetRoutingID()));
   widget_host_->OnMessageReceived(
       ViewHostMsg_UpdateScreenRects_ACK(widget_host_->GetRoutingID()));
   sink_->ClearMessages();
 
@@ skipping 46 matching lines @@
   ASSERT_TRUE(observer.destroyed());
 
   widget_host_ = nullptr;
   view_ = nullptr;
 }
 
 // Checks that a popup view is destroyed when a user clicks outside of the popup
 // view and focus does not change. This is the case when the user clicks on the
 // desktop background on Chrome OS.
 TEST_F(RenderWidgetHostViewAuraTest, DestroyPopupClickOutsidePopup) {
-  parent_view_->SetBounds(gfx::Rect(10, 10, 400, 400));
+  parent_view_->RequestTopLevelBoundsInScreen(gfx::Rect(10, 10, 400, 400));
   parent_view_->Focus();
   EXPECT_TRUE(parent_view_->HasFocus());
 
   view_->InitAsPopup(parent_view_, gfx::Rect(10, 10, 100, 100));
   aura::Window* window = view_->GetNativeView();
   ASSERT_TRUE(window != nullptr);
 
   gfx::Point click_point;
   EXPECT_FALSE(window->GetBoundsInRootWindow().Contains(click_point));
   aura::Window* parent_window = parent_view_->GetNativeView();
   EXPECT_FALSE(parent_window->GetBoundsInRootWindow().Contains(click_point));
 
   TestWindowObserver observer(window);
   ui::test::EventGenerator generator(window->GetRootWindow(), click_point);
   generator.ClickLeftButton();
   ASSERT_TRUE(parent_view_->HasFocus());
   ASSERT_TRUE(observer.destroyed());
 
   widget_host_ = nullptr;
   view_ = nullptr;
 }
 
 // Checks that a popup view is destroyed when a user taps outside of the popup
 // view and focus does not change. This is the case when the user taps the
 // desktop background on Chrome OS.
 TEST_F(RenderWidgetHostViewAuraTest, DestroyPopupTapOutsidePopup) {
-  parent_view_->SetBounds(gfx::Rect(10, 10, 400, 400));
+  parent_view_->RequestTopLevelBoundsInScreen(gfx::Rect(10, 10, 400, 400));
   parent_view_->Focus();
   EXPECT_TRUE(parent_view_->HasFocus());
 
   view_->InitAsPopup(parent_view_, gfx::Rect(10, 10, 100, 100));
   aura::Window* window = view_->GetNativeView();
   ASSERT_TRUE(window != nullptr);
 
   gfx::Point tap_point;
   EXPECT_FALSE(window->GetBoundsInRootWindow().Contains(tap_point));
   aura::Window* parent_window = parent_view_->GetNativeView();
   EXPECT_FALSE(parent_window->GetBoundsInRootWindow().Contains(tap_point));
 
   TestWindowObserver observer(window);
   ui::test::EventGenerator generator(window->GetRootWindow(), tap_point);
   generator.GestureTapAt(tap_point);
   ASSERT_TRUE(parent_view_->HasFocus());
   ASSERT_TRUE(observer.destroyed());
 
   widget_host_ = nullptr;
   view_ = nullptr;
 }
 
 #if defined(OS_LINUX) && !defined(OS_CHROMEOS)
 
 // On Desktop Linux, select boxes need mouse capture in order to work. Test that
 // when a select box is opened via a mouse press that it retains mouse capture
 // after the mouse is released.
 TEST_F(RenderWidgetHostViewAuraTest, PopupRetainsCaptureAfterMouseRelease) {
-  parent_view_->SetBounds(gfx::Rect(10, 10, 400, 400));
+  parent_view_->RequestTopLevelBoundsInScreen(gfx::Rect(10, 10, 400, 400));
   parent_view_->Focus();
   EXPECT_TRUE(parent_view_->HasFocus());
 
   ui::test::EventGenerator generator(
       parent_view_->GetNativeView()->GetRootWindow(), gfx::Point(300, 300));
   generator.PressLeftButton();
 
   view_->SetPopupType(blink::WebPopupTypePage);
   view_->InitAsPopup(parent_view_, gfx::Rect(10, 10, 100, 100));
   ASSERT_TRUE(view_->NeedsMouseCapture());
   aura::Window* window = view_->GetNativeView();
   EXPECT_TRUE(window->HasCapture());
 
   generator.ReleaseLeftButton();
   EXPECT_TRUE(window->HasCapture());
 }
 #endif
 
 // Test that select boxes close when their parent window loses focus (e.g. due
 // to an alert or system modal dialog).
 TEST_F(RenderWidgetHostViewAuraTest, PopupClosesWhenParentLosesFocus) {
-  parent_view_->SetBounds(gfx::Rect(10, 10, 400, 400));
+  parent_view_->RequestTopLevelBoundsInScreen(gfx::Rect(10, 10, 400, 400));
   parent_view_->Focus();
   EXPECT_TRUE(parent_view_->HasFocus());
 
   view_->SetPopupType(blink::WebPopupTypePage);
   view_->InitAsPopup(parent_view_, gfx::Rect(10, 10, 100, 100));
 
   aura::Window* popup_window = view_->GetNativeView();
   TestWindowObserver observer(popup_window);
 
   aura::test::TestWindowDelegate delegate;
@@ skipping 449 matching lines @@
 }
 
 TEST_F(RenderWidgetHostViewAuraTest, UpdateCursorIfOverSelf) {
   view_->InitAsChild(nullptr);
   aura::client::ParentWindowWithContext(
       view_->GetNativeView(),
       parent_view_->GetNativeView()->GetRootWindow(),
       gfx::Rect());
 
   // Note that all coordinates in this test are screen coordinates.
-  view_->SetBounds(gfx::Rect(60, 60, 100, 100));
+  view_->RequestTopLevelBoundsInScreen(gfx::Rect(60, 60, 100, 100));
   view_->Show();
 
   aura::test::TestCursorClient cursor_client(
       parent_view_->GetNativeView()->GetRootWindow());
 
   // Cursor is in the middle of the window.
   cursor_client.reset_calls_to_set_cursor();
   aura::Env::GetInstance()->set_last_mouse_location(gfx::Point(110, 110));
   view_->UpdateCursorIfOverSelf();
   EXPECT_EQ(1, cursor_client.calls_to_set_cursor());
@@ skipping 3053 matching lines @@
     // There is no composition in the beginning.
     EXPECT_FALSE(has_composition_text());
     SetHasCompositionTextToTrue();
     view->ImeCancelComposition();
     // The composition must have been canceled.
     EXPECT_FALSE(has_composition_text());
   }
 }
 
 }  // namespace content