Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Side by Side Diff: content/browser/renderer_host/render_widget_host_view_aura.h

Issue 2695093005: Remove RWHV::SetBounds() from the public API, and make comments clearer.
Patch Set: Revert web_contents_sizer to its previous shenanigans (http://crbug.com/693953). Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_AURA_H_ 5 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_AURA_H_
6 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_AURA_H_ 6 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_AURA_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
96 // the |widget|, a RenderWidgetHostViewGuest is. 96 // the |widget|, a RenderWidgetHostViewGuest is.
97 // 97 //
98 // TODO(lazyboy): Remove |is_guest_view_hack| once BrowserPlugin has migrated 98 // TODO(lazyboy): Remove |is_guest_view_hack| once BrowserPlugin has migrated
99 // to use RWHVChildFrame (http://crbug.com/330264). 99 // to use RWHVChildFrame (http://crbug.com/330264).
100 RenderWidgetHostViewAura(RenderWidgetHost* host, bool is_guest_view_hack); 100 RenderWidgetHostViewAura(RenderWidgetHost* host, bool is_guest_view_hack);
101 101
102 // RenderWidgetHostView implementation. 102 // RenderWidgetHostView implementation.
103 void InitAsChild(gfx::NativeView parent_view) override; 103 void InitAsChild(gfx::NativeView parent_view) override;
104 RenderWidgetHost* GetRenderWidgetHost() const override; 104 RenderWidgetHost* GetRenderWidgetHost() const override;
105 void SetSize(const gfx::Size& size) override; 105 void SetSize(const gfx::Size& size) override;
106 void SetBounds(const gfx::Rect& rect) override;
107 gfx::Vector2dF GetLastScrollOffset() const override; 106 gfx::Vector2dF GetLastScrollOffset() const override;
108 gfx::NativeView GetNativeView() const override; 107 gfx::NativeView GetNativeView() const override;
109 gfx::NativeViewAccessible GetNativeViewAccessible() override; 108 gfx::NativeViewAccessible GetNativeViewAccessible() override;
110 ui::TextInputClient* GetTextInputClient() override; 109 ui::TextInputClient* GetTextInputClient() override;
111 bool HasFocus() const override; 110 bool HasFocus() const override;
112 bool IsSurfaceAvailableForCopy() const override; 111 bool IsSurfaceAvailableForCopy() const override;
113 void Show() override; 112 void Show() override;
114 void Hide() override; 113 void Hide() override;
115 bool IsShowing() override; 114 bool IsShowing() override;
116 gfx::Rect GetViewBounds() const override; 115 gfx::Rect GetViewBounds() const override;
(...skipping 10 matching lines...) Expand all
127 const gfx::Rect& pos) override; 126 const gfx::Rect& pos) override;
128 void InitAsFullscreen(RenderWidgetHostView* reference_host_view) override; 127 void InitAsFullscreen(RenderWidgetHostView* reference_host_view) override;
129 void Focus() override; 128 void Focus() override;
130 void UpdateCursor(const WebCursor& cursor) override; 129 void UpdateCursor(const WebCursor& cursor) override;
131 void SetIsLoading(bool is_loading) override; 130 void SetIsLoading(bool is_loading) override;
132 void RenderProcessGone(base::TerminationStatus status, 131 void RenderProcessGone(base::TerminationStatus status,
133 int error_code) override; 132 int error_code) override;
134 void Destroy() override; 133 void Destroy() override;
135 void SetTooltipText(const base::string16& tooltip_text) override; 134 void SetTooltipText(const base::string16& tooltip_text) override;
136 gfx::Size GetRequestedRendererSize() const override; 135 gfx::Size GetRequestedRendererSize() const override;
136 void RequestTopLevelBoundsInScreen(const gfx::Rect& rect) override;
137 void CopyFromCompositingSurface( 137 void CopyFromCompositingSurface(
138 const gfx::Rect& src_subrect, 138 const gfx::Rect& src_subrect,
139 const gfx::Size& dst_size, 139 const gfx::Size& dst_size,
140 const ReadbackRequestCallback& callback, 140 const ReadbackRequestCallback& callback,
141 const SkColorType preferred_color_type) override; 141 const SkColorType preferred_color_type) override;
142 void CopyFromCompositingSurfaceToVideoFrame( 142 void CopyFromCompositingSurfaceToVideoFrame(
143 const gfx::Rect& src_subrect, 143 const gfx::Rect& src_subrect,
144 const scoped_refptr<media::VideoFrame>& target, 144 const scoped_refptr<media::VideoFrame>& target,
145 const base::Callback<void(const gfx::Rect&, bool)>& callback) override; 145 const base::Callback<void(const gfx::Rect&, bool)>& callback) override;
146 bool CanCopyToVideoFrame() const override; 146 bool CanCopyToVideoFrame() const override;
(...skipping 440 matching lines...) Expand 10 before | Expand all | Expand 10 after
587 std::unique_ptr<RenderWidgetHostViewEventHandler> event_handler_; 587 std::unique_ptr<RenderWidgetHostViewEventHandler> event_handler_;
588 588
589 base::WeakPtrFactory<RenderWidgetHostViewAura> weak_ptr_factory_; 589 base::WeakPtrFactory<RenderWidgetHostViewAura> weak_ptr_factory_;
590 590
591 DISALLOW_COPY_AND_ASSIGN(RenderWidgetHostViewAura); 591 DISALLOW_COPY_AND_ASSIGN(RenderWidgetHostViewAura);
592 }; 592 };
593 593
594 } // namespace content 594 } // namespace content
595 595
596 #endif // CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_AURA_H_ 596 #endif // CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_AURA_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698