Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Side by Side Diff: content/browser/renderer_host/render_widget_host_impl.cc

Issue 2695093005: Remove RWHV::SetBounds() from the public API, and make comments clearer.
Patch Set: Revert web_contents_sizer to its previous shenanigans (http://crbug.com/693953). Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/renderer_host/render_widget_host_impl.h" 5 #include "content/browser/renderer_host/render_widget_host_impl.h"
6 6
7 #include <math.h> 7 #include <math.h>
8 8
9 #include <set> 9 #include <set>
10 #include <tuple> 10 #include <tuple>
(...skipping 1784 matching lines...) Expand 10 before | Expand all | Expand 10 after
1795 if (view_->GetViewBounds() == last_view_screen_rect_ && 1795 if (view_->GetViewBounds() == last_view_screen_rect_ &&
1796 view_->GetBoundsInRootWindow() == last_window_screen_rect_) { 1796 view_->GetBoundsInRootWindow() == last_window_screen_rect_) {
1797 return; 1797 return;
1798 } 1798 }
1799 1799
1800 SendScreenRects(); 1800 SendScreenRects();
1801 } 1801 }
1802 1802
1803 void RenderWidgetHostImpl::OnRequestMove(const gfx::Rect& pos) { 1803 void RenderWidgetHostImpl::OnRequestMove(const gfx::Rect& pos) {
1804 if (view_) { 1804 if (view_) {
1805 view_->SetBounds(pos); 1805 view_->RequestTopLevelBoundsInScreen(pos);
1806 Send(new ViewMsg_Move_ACK(routing_id_)); 1806 Send(new ViewMsg_Move_ACK(routing_id_));
1807 } 1807 }
1808 } 1808 }
1809 1809
1810 bool RenderWidgetHostImpl::OnSwapCompositorFrame( 1810 bool RenderWidgetHostImpl::OnSwapCompositorFrame(
1811 const IPC::Message& message) { 1811 const IPC::Message& message) {
1812 // This trace event is used in 1812 // This trace event is used in
1813 // chrome/browser/extensions/api/cast_streaming/performance_test.cc 1813 // chrome/browser/extensions/api/cast_streaming/performance_test.cc
1814 TRACE_EVENT0("test_fps,benchmark", "OnSwapCompositorFrame"); 1814 TRACE_EVENT0("test_fps,benchmark", "OnSwapCompositorFrame");
1815 1815
(...skipping 693 matching lines...) Expand 10 before | Expand all | Expand 10 after
2509 // different from the receiver's. 2509 // different from the receiver's.
2510 file_system_file.url = 2510 file_system_file.url =
2511 GURL(storage::GetIsolatedFileSystemRootURIString( 2511 GURL(storage::GetIsolatedFileSystemRootURIString(
2512 file_system_url.origin(), filesystem_id, std::string()) 2512 file_system_url.origin(), filesystem_id, std::string())
2513 .append(register_name)); 2513 .append(register_name));
2514 file_system_file.filesystem_id = filesystem_id; 2514 file_system_file.filesystem_id = filesystem_id;
2515 } 2515 }
2516 } 2516 }
2517 2517
2518 } // namespace content 2518 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698