Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Side by Side Diff: content/browser/frame_host/render_widget_host_view_guest.h

Issue 2695093005: Remove RWHV::SetBounds() from the public API, and make comments clearer.
Patch Set: Revert web_contents_sizer to its previous shenanigans (http://crbug.com/693953). Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_FRAME_HOST_RENDER_WIDGET_HOST_VIEW_GUEST_H_ 5 #ifndef CONTENT_BROWSER_FRAME_HOST_RENDER_WIDGET_HOST_VIEW_GUEST_H_
6 #define CONTENT_BROWSER_FRAME_HOST_RENDER_WIDGET_HOST_VIEW_GUEST_H_ 6 #define CONTENT_BROWSER_FRAME_HOST_RENDER_WIDGET_HOST_VIEW_GUEST_H_
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
50 base::WeakPtr<RenderWidgetHostViewBase> platform_view); 50 base::WeakPtr<RenderWidgetHostViewBase> platform_view);
51 ~RenderWidgetHostViewGuest() override; 51 ~RenderWidgetHostViewGuest() override;
52 52
53 bool OnMessageReceivedFromEmbedder(const IPC::Message& message, 53 bool OnMessageReceivedFromEmbedder(const IPC::Message& message,
54 RenderWidgetHostImpl* embedder); 54 RenderWidgetHostImpl* embedder);
55 55
56 // RenderWidgetHostView implementation. 56 // RenderWidgetHostView implementation.
57 bool OnMessageReceived(const IPC::Message& msg) override; 57 bool OnMessageReceived(const IPC::Message& msg) override;
58 void InitAsChild(gfx::NativeView parent_view) override; 58 void InitAsChild(gfx::NativeView parent_view) override;
59 void SetSize(const gfx::Size& size) override; 59 void SetSize(const gfx::Size& size) override;
60 void SetBounds(const gfx::Rect& rect) override;
61 void Focus() override; 60 void Focus() override;
62 bool HasFocus() const override; 61 bool HasFocus() const override;
63 void Show() override; 62 void Show() override;
64 void Hide() override; 63 void Hide() override;
65 gfx::NativeView GetNativeView() const override; 64 gfx::NativeView GetNativeView() const override;
66 gfx::NativeViewAccessible GetNativeViewAccessible() override; 65 gfx::NativeViewAccessible GetNativeViewAccessible() override;
67 gfx::Rect GetViewBounds() const override; 66 gfx::Rect GetViewBounds() const override;
68 gfx::Rect GetBoundsInRootWindow() override; 67 gfx::Rect GetBoundsInRootWindow() override;
69 gfx::Size GetPhysicalBackingSize() const override; 68 gfx::Size GetPhysicalBackingSize() const override;
70 base::string16 GetSelectedText() override; 69 base::string16 GetSelectedText() override;
71 void SetNeedsBeginFrames(bool needs_begin_frames) override; 70 void SetNeedsBeginFrames(bool needs_begin_frames) override;
72 71
73 // RenderWidgetHostViewBase implementation. 72 // RenderWidgetHostViewBase implementation.
74 void InitAsPopup(RenderWidgetHostView* parent_host_view, 73 void InitAsPopup(RenderWidgetHostView* parent_host_view,
75 const gfx::Rect& bounds) override; 74 const gfx::Rect& bounds) override;
76 void InitAsFullscreen(RenderWidgetHostView* reference_host_view) override; 75 void InitAsFullscreen(RenderWidgetHostView* reference_host_view) override;
76 void RequestTopLevelBoundsInScreen(const gfx::Rect& rect) override;
77 void UpdateCursor(const WebCursor& cursor) override; 77 void UpdateCursor(const WebCursor& cursor) override;
78 void SetIsLoading(bool is_loading) override; 78 void SetIsLoading(bool is_loading) override;
79 void TextInputStateChanged(const TextInputState& params) override; 79 void TextInputStateChanged(const TextInputState& params) override;
80 void ImeCancelComposition() override; 80 void ImeCancelComposition() override;
81 #if defined(OS_MACOSX) || defined(USE_AURA) 81 #if defined(OS_MACOSX) || defined(USE_AURA)
82 void ImeCompositionRangeChanged( 82 void ImeCompositionRangeChanged(
83 const gfx::Range& range, 83 const gfx::Range& range,
84 const std::vector<gfx::Rect>& character_bounds) override; 84 const std::vector<gfx::Rect>& character_bounds) override;
85 #endif 85 #endif
86 void RenderProcessGone(base::TerminationStatus status, 86 void RenderProcessGone(base::TerminationStatus status,
(...skipping 74 matching lines...) Expand 10 before | Expand all | Expand 10 after
161 // The platform view for this RenderWidgetHostView. 161 // The platform view for this RenderWidgetHostView.
162 // RenderWidgetHostViewGuest mostly only cares about stuff related to 162 // RenderWidgetHostViewGuest mostly only cares about stuff related to
163 // compositing, the rest are directly forwarded to this |platform_view_|. 163 // compositing, the rest are directly forwarded to this |platform_view_|.
164 base::WeakPtr<RenderWidgetHostViewBase> platform_view_; 164 base::WeakPtr<RenderWidgetHostViewBase> platform_view_;
165 DISALLOW_COPY_AND_ASSIGN(RenderWidgetHostViewGuest); 165 DISALLOW_COPY_AND_ASSIGN(RenderWidgetHostViewGuest);
166 }; 166 };
167 167
168 } // namespace content 168 } // namespace content
169 169
170 #endif // CONTENT_BROWSER_FRAME_HOST_RENDER_WIDGET_HOST_VIEW_GUEST_H_ 170 #endif // CONTENT_BROWSER_FRAME_HOST_RENDER_WIDGET_HOST_VIEW_GUEST_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698