Remove RWHV::SetBounds() from the public API, and make comments clearer.

chrome/browser/ui/web_contents_sizer.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/web_contents_sizer.h"
 
 #include "build/build_config.h"
 #include "content/public/browser/web_contents.h"
 
 #if defined(USE_AURA)
 #include "ui/aura/window.h"
 #elif defined(OS_ANDROID)
 #include "content/public/browser/render_widget_host_view.h"
 #endif
 
 void ResizeWebContents(content::WebContents* web_contents,
                        const gfx::Rect& new_bounds) {
 #if defined(USE_AURA)
+  // TODO(miu): This is a layering violation, since only the RWHV should know

[sky, 2017/02/16 00:29:02]

I don't understand this comment (or the one in the mac file). Why is it wrong to
resize here? This comment also doesn't apply to the USE_AURA case it's resizing
the WebContents.

[miu, 2017/02/17 00:09:02]

A few reasons:

1. We're in the platform-agnostic part of the UI code (i.e., not in a "views" or
"cocoa" dir), so it's already a little strange to have per-platform conditional
code compiles here.

2. Encapsulation: This directly modifies the size of the RenderWidgetHostView's
native view. However, shouldn't that be done through the RWHV class itself,
where it knows more about whether/how the size should be changed for specific
platforms?

3. It seems that this utility function actually isn't needed at all. Callers
could just call web_contents->GetRenderWidgetHostView()->SetSize() themselves.

[sky, 2017/02/17 16:53:07]

Could point on the first 1. This code should really be in the platform specific
directories. But I like you're third comment about removing entirely.

[miu, 2017/02/17 23:50:59]

Sounds like we agree with the change. I was about to revise my TODO comment, but
this is such a simple thing and it should not cause any behavior change; and so
I just went ahead and did it. :) LGTY?

I'll get rid of ResizeWebContents() altogether in a follow-up change.

Also, a weirdness: This function takes a gfx::Rect, but only the size is ever
used. I've added yusufo@ to this code review to confirm the position isn't
actually needed on Android.

+  // whether the resize operation is valid and, if so, execute it.
+  // http://crbug.com/73362
   aura::Window* window = web_contents->GetNativeView();
   window->SetBounds(gfx::Rect(window->bounds().origin(), new_bounds.size()));
 #elif defined(OS_ANDROID)
   content::RenderWidgetHostView* view = web_contents->GetRenderWidgetHostView();
   if (view)
-    view->SetBounds(new_bounds);
+    view->RequestTopLevelBoundsInScreen(new_bounds);
 #endif
 }