third_party/WebKit/LayoutTests/http/tests/serviceworker/postmessage-blob-url.html - Issue 2695093003: Add LayoutTests to test Blob URL transfer to {Shared,Service}Workers

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/serviceworker/postmessage-blob-url.html

Issue 2695093003: Add LayoutTests to test Blob URL transfer to {Shared,Service}Workers (Closed)

Patch Set: . Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/workers/shared-worker-blob-url.html ('k') | third_party/WebKit/LayoutTests/http/tests/serviceworker/resources/postmessage-blob-url.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <title>Service Worker: postMessage Blob URL</title>

	3 <script src="../resources/testharness.js"></script>

	4 <script src="../resources/testharnessreport.js"></script>

	5 <script src="resources/test-helpers.js"></script>

	6 <script>

	7

	8 promise_test(t => {

	9 let script = 'resources/postmessage-blob-url.js';

	10 let scope = 'resources/blank.html';

	11 let registration;

	12 let worker;

	13 let port;

	14 let blobText = 'Blob text';

	15 let blob;

	16 let blobUrl;

	17

	18 return service_worker_unregister_and_register(t, script, scope)

	19 .then(r => {

	20 add_completion_callback(() => r.unregister());

	21 registration = r;

	22 worker = registration.installing;

	23

	24 var messageChannel = new MessageChannel();

	25 port = messageChannel.port1;

	26 return new Promise(resolve => {

	27 port.onmessage = resolve;

	28 worker.postMessage({port: messageChannel.port2},

	29 [messageChannel.port2]);

	30 });
	falken 2017/02/15 04:46:06 would it be simpler to just do worker.postMessage( would it be simpler to just do worker.postMessage() and have the worker do event.source.postMessage() back, instead of the MessageChannel? "messageChannel" has to be repeated like 5 times so I try to avoid it. also if using MessageChannel, I don't think you need to pass "port" as part of the message data. In onmessage the worker can do e.ports[0].postMessage. kinuko 2017/02/15 07:10:16 Done. Show quoted text On 2017/02/15 04:46:06, falken wrote: > would it be simpler to just do worker.postMessage() and have the worker do > event.source.postMessage() back, instead of the MessageChannel? "messageChannel" > has to be repeated like 5 times so I try to avoid it. > > also if using MessageChannel, I don't think you need to pass "port" as part of > the message data. In onmessage the worker can do e.ports[0].postMessage. Done.
	31 })

	32 .then(e => {

	33 assert_equals(e.data, 'Connected');
	falken 2017/02/15 04:46:06 Do we need the "Connected" step? Can't we send blo Do we need the "Connected" step? Can't we send blobUrl as the first postMessage? kinuko 2017/02/15 07:10:16 Well, I ended up removing this step. Show quoted text On 2017/02/15 04:46:06, falken wrote: > Do we need the "Connected" step? Can't we send blobUrl as the first postMessage? Well, I ended up removing this step.
	34 blob = new Blob([blobText]);

	35 blobUrl = URL.createObjectURL(blob);

	36 port.postMessage(blobUrl);

	37 return new Promise(resolve => { port.onmessage = resolve; });

	38 })

	39 .then(e => {

	40 assert_equals(e.data, 'Worker reply:' + blobText);

	41 URL.revokeObjectURL(blobUrl);

	42 return registration.unregister(scope);

	43 });

	44 }, 'postMessage Blob URL to a ServiceWorker');

	45

	46 </script>

	47

OLD	NEW