Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(375)

Unified Diff: third_party/WebKit/Source/web/WebFrameWidgetBase.cpp

Issue 2695043002: Speculative fix for crash in blink::WebFrameWidgetBase::dragTargetDragEnterOrOver (Closed)
Patch Set: Added TODO. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/web/WebFrameWidgetBase.cpp
diff --git a/third_party/WebKit/Source/web/WebFrameWidgetBase.cpp b/third_party/WebKit/Source/web/WebFrameWidgetBase.cpp
index 79e51fc74f47f7e990c4f1dec0e24542238a19db..b9139dc30dec1ac97a37cc9e4ec9f21297ec093a 100644
--- a/third_party/WebKit/Source/web/WebFrameWidgetBase.cpp
+++ b/third_party/WebKit/Source/web/WebFrameWidgetBase.cpp
@@ -177,7 +177,12 @@ WebDragOperation WebFrameWidgetBase::dragTargetDragEnterOrOver(
DragAction dragAction,
int modifiers) {
DCHECK(m_currentDragData);
- if (ignoreInputEvents()) {
+ // TODO(paulmeyer): It shouldn't be possible for |m_currentDragData| to be
+ // null here, but this is somehow happening (rarely). This suggests that in
+ // some cases drag-over is happening before drag-enter, which should be
+ // impossible. This needs to be investigated further. Once fixed, the extra
+ // check for |!m_currentDragData| should be removed. (crbug.com/671504)
+ if (ignoreInputEvents() || !m_currentDragData) {
cancelDrag();
return WebDragOperationNone;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698