Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Unified Diff: chromeos/chromeos_switches.cc

Issue 2694923005: Appropriate handling for Cellular First devices. (Closed)
Patch Set: rebased Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromeos/chromeos_switches.h ('k') | chromeos/dbus/fake_update_engine_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/chromeos_switches.cc
diff --git a/chromeos/chromeos_switches.cc b/chromeos/chromeos_switches.cc
index ca2273ecef8a1fe8f67e40053ee4081163392803..68016fdb8e384764e0173f645faa9728b275521e 100644
--- a/chromeos/chromeos_switches.cc
+++ b/chromeos/chromeos_switches.cc
@@ -37,12 +37,6 @@ const char kAggressiveTabDiscardThreshold[] = "aggressive-tab-discard";
const char kAggressiveThreshold[] = "aggressive";
-// If this flag is set, enable data roaming in the cellular network by default
-// upon system start if it's an unmanaged device. This flag is used by Rialto
-// device to obtain device policy during OOBE since the Rialto device has no
-// display and and only connects over cell.
-const char kAllowDataRoamingByDefault[] = "allow-data-roaming-by-default";
-
// If this flag is passed, failed policy fetches will not cause profile
// initialization to fail. This is useful for tests because it means that
// tests don't have to mock out the policy infrastructure.
@@ -88,6 +82,15 @@ const char kArtifactsDir[] = "artifacts-dir";
// Possible values: parallel|postpone. Default: parallel.
const char kAshWebUIInit[] = "ash-webui-init";
+// If this flag is set, it indicates that this device is a "Cellular First"
+// device. Cellular First devices use cellular telephone data networks as
+// their primary means of connecting to the internet.
+// Setting this flag has two consequences:
+// 1. Cellular data roaming will be enabled by default.
+// 2. UpdateEngine will be instructed to allow auto-updating over cellular
+// data connections.
+const char kCellularFirst[] = "cellular-first";
+
// Default large wallpaper to use for kids accounts (as path to trusted,
// non-user-writable JPEG file).
const char kChildWallpaperLarge[] = "child-wallpaper-large";
@@ -508,5 +511,9 @@ bool IsGaiaIdMigrationStarted() {
kTestCrosGaiaIdMigrationStarted;
}
+bool IsCellularFirstDevice() {
+ return base::CommandLine::ForCurrentProcess()->HasSwitch(kCellularFirst);
+}
+
} // namespace switches
} // namespace chromeos
« no previous file with comments | « chromeos/chromeos_switches.h ('k') | chromeos/dbus/fake_update_engine_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698