Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5866)

Unified Diff: chrome/browser/chromeos/policy/device_network_configuration_updater.cc

Issue 2694923005: Appropriate handling for Cellular First devices. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/policy/device_network_configuration_updater.cc
diff --git a/chrome/browser/chromeos/policy/device_network_configuration_updater.cc b/chrome/browser/chromeos/policy/device_network_configuration_updater.cc
index 301a0749a6fb9c06b92adfbf41a49b5f9b3aba2a..6bc15d75030db369c70d310a569d5f29af120942 100644
--- a/chrome/browser/chromeos/policy/device_network_configuration_updater.cc
+++ b/chrome/browser/chromeos/policy/device_network_configuration_updater.cc
@@ -59,14 +59,10 @@ DeviceNetworkConfigurationUpdater::DeviceNetworkConfigurationUpdater(
void DeviceNetworkConfigurationUpdater::Init() {
NetworkConfigurationUpdater::Init();
- // TODO(xdai): kAllowDataRoamingByDefault is only used by Rialto devices for
- // development/testing purpose. After Rialto migrates to use KIOSK app mode,
- // remove this part of logic.
- const policy::BrowserPolicyConnectorChromeOS* connector =
- g_browser_process->platform_part()->browser_policy_connector_chromeos();
- if (!connector->IsEnterpriseManaged() &&
- base::CommandLine::ForCurrentProcess()->HasSwitch(
- chromeos::switches::kAllowDataRoamingByDefault)) {
+ // If this is a Cellular First device, then cellular data roaming
+ // should be allowed by default.
+ if (base::CommandLine::ForCurrentProcess()->HasSwitch(
+ chromeos::switches::kCellularFirst)) {
network_device_handler_->SetCellularAllowRoaming(true);
} else {
// Apply the roaming setting initially.
@@ -74,6 +70,8 @@ void DeviceNetworkConfigurationUpdater::Init() {
}
// Set up MAC address randomization if we are not enterprise managed.
+ const policy::BrowserPolicyConnectorChromeOS* connector =
+ g_browser_process->platform_part()->browser_policy_connector_chromeos();
network_device_handler_->SetMACAddressRandomizationEnabled(
!connector->IsEnterpriseManaged());
}

Powered by Google App Engine
This is Rietveld 408576698