Appropriate handling for Cellular First devices.

chrome/browser/chromeos/login/wizard_controller.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/login/wizard_controller.h"
 
 #include <signal.h>
 #include <stddef.h>
 #include <stdlib.h>
 #include <sys/types.h>
@@ skipping 72 matching lines @@
 #include "chromeos/timezone/timezone_provider.h"
 #include "components/crash/content/app/breakpad_linux.h"
 #include "components/pairing/bluetooth_controller_pairing_controller.h"
 #include "components/pairing/bluetooth_host_pairing_controller.h"
 #include "components/pairing/shark_connection_listener.h"
 #include "components/prefs/pref_registry_simple.h"
 #include "components/prefs/pref_service.h"
 #include "components/user_manager/user_manager.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/notification_types.h"
+#include "dbus/message.h"
 #include "ui/base/accelerators/accelerator.h"
 
 using content::BrowserThread;
 
 namespace {
 // Interval in ms which is used for smooth screen showing.
 static int kShowDelayMs = 400;
 
 // Total timezone resolving process timeout.
 const unsigned int kResolveTimeZoneTimeoutSeconds = 60;
@@ skipping 779 matching lines @@
   }
 }
 
 void WizardController::InitiateOOBEUpdate() {
   if (IsRemoraRequisition()) {
     VLOG(1) << "Skip OOBE Update for remora.";
     OnUpdateCompleted();
     return;
   }
 
+  // If this is a Cellular First device, instruct UpdateEngine to allow
+  // updates over cellular data connections.
+  if (base::CommandLine::ForCurrentProcess()->HasSwitch(

[xiyuan, 2017/02/14 17:06:10]

nit: Move this block into a help function (e.g. MaybeAllowUpdateOverCellular) in
anonymous namespace and call it here.

[kumarniranjan, 2017/02/28 19:01:39]

I decided to name it IsCellularFirstDevice because that is most descriptive of
what it is doing. Please let me know if you don't think it is a good name.

+          chromeos::switches::kCellularFirst)) {
+    std::unique_ptr<dbus::Response> response =
+        DBusThreadManager::Get()
+            ->GetUpdateEngineClient()
+            ->SetUpdateOverCellularPermission(true);
+    switch (response->GetMessageType()) {
+      case dbus::Message::MESSAGE_ERROR:
+        LOG(ERROR) << "DBus Error: " << response->ToString();
+      // Intentional fallthrough.
+      case dbus::Message::MESSAGE_INVALID:
+        // MESSAGE_INVALID means the DBus response cannot be parsed.
+        LOG(ERROR) << "Failed to set UpdateEngine to allow updates over cell.";
+        break;
+      default:
+        VLOG(1) << "Successfully set UpdateEngine to allow update over cell.";
+        break;
+    }
+  }
+
   VLOG(1) << "InitiateOOBEUpdate";
   SetCurrentScreenSmooth(GetScreen(OobeScreen::SCREEN_OOBE_UPDATE), true);
   UpdateScreen::Get(this)->StartNetworkCheck();
 }
 
 void WizardController::StartTimezoneResolve() {
   geolocation_provider_.reset(new SimpleGeolocationProvider(
       g_browser_process->system_request_context(),
       SimpleGeolocationProvider::DefaultGeolocationProviderURL()));
   geolocation_provider_->RequestGeolocation(
@@ skipping 604 matching lines @@
             : policy::EnrollmentConfig::MODE_MANUAL_REENROLLMENT;
   }
 
   EnrollmentScreen* screen = EnrollmentScreen::Get(this);
   screen->SetParameters(effective_config, shark_controller_.get());
   SetStatusAreaVisible(true);
   SetCurrentScreen(screen);
 }
 
 }  // namespace chromeos