Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(220)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2694923002: DevTools: Changes Drawer (Closed)

Created:
3 years, 10 months ago by einbinder
Modified:
3 years, 8 months ago
Reviewers:
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Changes Drawer BUG=610061

Patch Set 1 #

Patch Set 2 : Undo icon #

Total comments: 5

Patch Set 3 : slightly better #

Total comments: 15

Patch Set 4 : placeholder text #

Patch Set 5 : syntax highlighting #

Patch Set 6 : Remove event listener on willHide #

Unified diffs Side-by-side diffs Delta from patch set Stats (+927 lines, -18 lines) Patch
M third_party/WebKit/Source/devtools/BUILD.gn View 1 2 3 4 5 2 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/Images/smallIcons.png View 1 2 3 4 5 Binary file 0 comments Download
M third_party/WebKit/Source/devtools/front_end/Images/smallIcons_2x.png View 1 2 3 4 5 Binary file 0 comments Download
M third_party/WebKit/Source/devtools/front_end/Images/src/optimize_png.hashes View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/Images/src/svg2png.hashes View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/Images/src/toolbarButtonGlyphs.svg View 1 2 3 4 5 1 chunk +142 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/Images/toolbarButtonGlyphs.png View 1 2 3 4 5 Binary file 0 comments Download
M third_party/WebKit/Source/devtools/front_end/Images/toolbarButtonGlyphs_2x.png View 1 2 3 4 5 Binary file 0 comments Download
A third_party/WebKit/Source/devtools/front_end/changes/ChangesView.js View 1 2 3 4 5 1 chunk +579 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/devtools/front_end/changes/changesView.css View 1 2 3 4 1 chunk +65 lines, -0 lines 0 comments Download
A third_party/WebKit/Source/devtools/front_end/changes/module.json View 1 chunk +28 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/common/CharacterIdMap.js View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/diff/Diff.js View 1 2 3 4 5 1 chunk +6 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/externs.js View 1 2 3 4 5 3 chunks +13 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/inspector.json View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/NavigatorView.js View 1 2 3 4 10 chunks +53 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/text_editor/CodeMirrorTextEditor.js View 1 2 3 4 5 3 chunks +17 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/Icon.js View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/TextEditor.js View 1 2 3 4 5 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js View 1 2 3 4 4 chunks +12 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 2729783002 Patch 240001

Messages

Total messages: 9 (3 generated)
einbinder
ptal
3 years, 10 months ago (2017-02-13 23:38:34 UTC) #3
lushnikov
https://codereview.chromium.org/2694923002/diff/20001/third_party/WebKit/Source/devtools/front_end/changes/ChangesView.js File third_party/WebKit/Source/devtools/front_end/changes/ChangesView.js (right): https://codereview.chromium.org/2694923002/diff/20001/third_party/WebKit/Source/devtools/front_end/changes/ChangesView.js#newcode104 third_party/WebKit/Source/devtools/front_end/changes/ChangesView.js:104: this._rows = []; this is scary to follow https://codereview.chromium.org/2694923002/diff/20001/third_party/WebKit/Source/devtools/front_end/changes/ChangesView.js#newcode140 ...
3 years, 10 months ago (2017-02-14 00:05:11 UTC) #4
lushnikov
https://codereview.chromium.org/2694923002/diff/40001/third_party/WebKit/Source/devtools/front_end/changes/ChangesView.js File third_party/WebKit/Source/devtools/front_end/changes/ChangesView.js (right): https://codereview.chromium.org/2694923002/diff/40001/third_party/WebKit/Source/devtools/front_end/changes/ChangesView.js#newcode6 third_party/WebKit/Source/devtools/front_end/changes/ChangesView.js:6: * @unrestricted why? https://codereview.chromium.org/2694923002/diff/40001/third_party/WebKit/Source/devtools/front_end/changes/ChangesView.js#newcode7 third_party/WebKit/Source/devtools/front_end/changes/ChangesView.js:7: * @implements {UI.ListDelegate} template ...
3 years, 10 months ago (2017-02-15 02:29:54 UTC) #5
lushnikov
https://codereview.chromium.org/2694923002/diff/40001/third_party/WebKit/Source/devtools/front_end/changes/ChangesView.js File third_party/WebKit/Source/devtools/front_end/changes/ChangesView.js (right): https://codereview.chromium.org/2694923002/diff/40001/third_party/WebKit/Source/devtools/front_end/changes/ChangesView.js#newcode413 third_party/WebKit/Source/devtools/front_end/changes/ChangesView.js:413: CodeMirror.defineMode('devtools-diff', function() { this potentially will cache the outdated ...
3 years, 10 months ago (2017-02-15 02:39:19 UTC) #6
einbinder
https://codereview.chromium.org/2694923002/diff/40001/third_party/WebKit/Source/devtools/front_end/changes/ChangesView.js File third_party/WebKit/Source/devtools/front_end/changes/ChangesView.js (right): https://codereview.chromium.org/2694923002/diff/40001/third_party/WebKit/Source/devtools/front_end/changes/ChangesView.js#newcode6 third_party/WebKit/Source/devtools/front_end/changes/ChangesView.js:6: * @unrestricted On 2017/02/15 at 02:29:54, lushnikov wrote: > ...
3 years, 9 months ago (2017-03-14 01:19:36 UTC) #7
einbinder
3 years, 9 months ago (2017-03-14 21:06:18 UTC) #9 

          

          

        


      

    

    

  











      		
    

  





  
    
  






  Powered by Google App Engine





  
This is Rietveld 408576698