Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1266)

Unified Diff: ui/views/controls/menu/menu_item_view.cc

Issue 2694903010: AX checked state changes (Closed)
Patch Set: git cl try Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/views/controls/button/toggle_button.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/controls/menu/menu_item_view.cc
diff --git a/ui/views/controls/menu/menu_item_view.cc b/ui/views/controls/menu/menu_item_view.cc
index 450cf5ac36534dc54c3bc2a45efa8cae66f045bb..46ff17be1aec4f3ee0310ea9324da10cf58785c4 100644
--- a/ui/views/controls/menu/menu_item_view.cc
+++ b/ui/views/controls/menu/menu_item_view.cc
@@ -174,10 +174,12 @@ void MenuItemView::GetAccessibleNodeData(ui::AXNodeData* node_data) {
node_data->AddStateFlag(ui::AX_STATE_HASPOPUP);
break;
case CHECKBOX:
- case RADIO:
- if (GetDelegate()->IsItemChecked(GetCommand()))
- node_data->AddStateFlag(ui::AX_STATE_CHECKED);
- break;
+ case RADIO: {
+ const bool is_checked = GetDelegate()->IsItemChecked(GetCommand());
+ const ui::AXCheckedState checked_state =
+ is_checked ? ui::AX_CHECKED_STATE_TRUE : ui::AX_CHECKED_STATE_FALSE;
+ node_data->AddIntAttribute(ui::AX_ATTR_CHECKED_STATE, checked_state);
+ } break;
case NORMAL:
case SEPARATOR:
case EMPTY:
« no previous file with comments | « ui/views/controls/button/toggle_button.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698