Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Unified Diff: third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp

Issue 2694903010: AX checked state changes (Closed)
Patch Set: git cl try Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp
diff --git a/third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp b/third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp
index 7b06537048cadfb895bee5c2fb03f3604937fdce..71d00424224c7fd8431fa5737b9ab11c095d5ce5 100644
--- a/third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp
+++ b/third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp
@@ -1143,36 +1143,6 @@ bool AXNodeObject::IsNativeSlider() const {
return toHTMLInputElement(node)->type() == InputTypeNames::range;
}
-bool AXNodeObject::IsChecked() const {
- Node* node = this->GetNode();
- if (!node)
- return false;
-
- // First test for native checkedness semantics
- if (isHTMLInputElement(*node))
- return toHTMLInputElement(*node).ShouldAppearChecked();
-
- // Else, if this is an ARIA role checkbox or radio or menuitemcheckbox
- // or menuitemradio or switch, respect the aria-checked attribute
- switch (AriaRoleAttribute()) {
- case kCheckBoxRole:
- case kMenuItemCheckBoxRole:
- case kMenuItemRadioRole:
- case kRadioButtonRole:
- case kSwitchRole:
- if (EqualIgnoringASCIICase(
- GetAOMPropertyOrARIAAttribute(AOMStringProperty::kChecked),
- "true"))
- return true;
- return false;
- default:
- break;
- }
-
- // Otherwise it's not checked
- return false;
-}
-
bool AXNodeObject::IsClickable() const {
if (GetNode()) {
if (GetNode()->IsElementNode() &&
@@ -1607,16 +1577,6 @@ String AXNodeObject::GetText() const {
return ToElement(node)->innerText();
}
-AccessibilityButtonState AXNodeObject::CheckboxOrRadioValue() const {
- if (IsNativeCheckboxInMixedState())
- return kButtonStateMixed;
-
- if (IsNativeCheckboxOrRadio())
- return IsChecked() ? kButtonStateOn : kButtonStateOff;
-
- return AXObject::CheckboxOrRadioValue();
-}
-
RGBA32 AXNodeObject::ColorValue() const {
if (!isHTMLInputElement(GetNode()) || !IsColorWell())
return AXObject::ColorValue();
@@ -1856,15 +1816,6 @@ static bool IsInSameNonInlineBlockFlow(LayoutObject* r1, LayoutObject* r2) {
return b1 && b2 && b1 == b2;
}
-bool AXNodeObject::IsNativeCheckboxInMixedState() const {
- if (!isHTMLInputElement(node_))
- return false;
-
- HTMLInputElement* input = toHTMLInputElement(node_);
- return input->type() == InputTypeNames::checkbox &&
- input->ShouldAppearIndeterminate();
-}
-
//
// New AX name calculation.
//

Powered by Google App Engine
This is Rietveld 408576698