Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(682)

Unified Diff: ui/accessibility/platform/ax_platform_node_win.cc

Issue 2694903010: AX checked state changes (Closed)
Patch Set: Test checkbox attribute in automation API, fix whitespace, remove change to third party code Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/accessibility/platform/ax_platform_node_win.cc
diff --git a/ui/accessibility/platform/ax_platform_node_win.cc b/ui/accessibility/platform/ax_platform_node_win.cc
index d811182f2f17fceaac6f803e3c159df170953c28..40688166bd8ed85cb21a9800a578f1707169ff7b 100644
--- a/ui/accessibility/platform/ax_platform_node_win.cc
+++ b/ui/accessibility/platform/ax_platform_node_win.cc
@@ -1045,11 +1045,10 @@ int AXPlatformNodeWin::MSAARole() {
}
int AXPlatformNodeWin::MSAAState() {
- uint32_t state = GetData().state;
+ const AXNodeData& data = GetData();
+ const uint32_t state = data.state;
int msaa_state = 0;
- if (state & (1 << ui::AX_STATE_CHECKED))
- msaa_state |= STATE_SYSTEM_CHECKED;
if (state & (1 << ui::AX_STATE_COLLAPSED))
msaa_state |= STATE_SYSTEM_COLLAPSED;
if (state & (1 << ui::AX_STATE_DEFAULT))
@@ -1081,6 +1080,19 @@ int AXPlatformNodeWin::MSAAState() {
if (state & (1 << ui::AX_STATE_DISABLED))
msaa_state |= STATE_SYSTEM_UNAVAILABLE;
+ // Checked state
+ const int checked = GetIntAttribute(ui::AX_ATTR_CHECKED_STATE);
+ switch (checked) {
+ case ui::AX_CHECKED_STATE_TRUE:
+ msaa_state |= STATE_SYSTEM_CHECKED;
+ break;
+ case ui::AX_CHECKED_STATE_MIXED:
+ msaa_state |= STATE_SYSTEM_MIXED;
+ break;
+ default:
+ break;
+ }
+
gfx::NativeViewAccessible focus = delegate_->GetFocus();
if (focus == GetNativeViewAccessible())
msaa_state |= STATE_SYSTEM_FOCUSED;
@@ -1091,7 +1103,7 @@ int AXPlatformNodeWin::MSAAState() {
// TODO(dmazzoni): this should probably check if focus is actually inside
// the menu bar, but we don't currently track focus inside menu pop-ups,
// and Chrome only has one menu visible at a time so this works for now.
- if (GetData().role == ui::AX_ROLE_MENU_BAR &&
+ if (data.role == ui::AX_ROLE_MENU_BAR &&
!(state & (1 << ui::AX_STATE_INVISIBLE))) {
msaa_state |= STATE_SYSTEM_FOCUSED;
}

Powered by Google App Engine
This is Rietveld 408576698