content/browser/accessibility/browser_accessibility_win_unittest.cc - Issue 2694903010: AX checked state changes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/accessibility/browser_accessibility_win_unittest.cc

Issue 2694903010: AX checked state changes (Closed)

Patch Set: Test checkbox attribute in automation API, fix whitespace, remove change to third party code Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js ('K') | « content/browser/accessibility/browser_accessibility_win.cc ('k') | content/renderer/accessibility/blink_ax_enum_conversion.h » ('j') | third_party/WebKit/LayoutTests/accessibility/input-mixed.html » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/accessibility/browser_accessibility_win_unittest.cc

diff --git a/content/browser/accessibility/browser_accessibility_win_unittest.cc b/content/browser/accessibility/browser_accessibility_win_unittest.cc

index dfa63aaa06350f2d35bf4301eb3ea1112dc08a14..4b3f8ac3b5b8f7d9e763afa39570e247db4dbb03 100644

--- a/content/browser/accessibility/browser_accessibility_win_unittest.cc

+++ b/content/browser/accessibility/browser_accessibility_win_unittest.cc

@@ -599,7 +599,9 @@ TEST_F(BrowserAccessibilityTest, TestComplexHypertext) {

ui::AXNodeData check_box;

check_box.id = 14;

check_box.role = ui::AX_ROLE_CHECK_BOX;

- check_box.state = 1 << ui::AX_STATE_CHECKED;

+ check_box.state = 0;

+ check_box.AddIntAttribute(ui::AX_ATTR_CHECKED_STATE,

+ ui::AX_CHECKED_STATE_TRUE);

check_box.SetName(base::UTF16ToUTF8(check_box_name));

check_box.SetValue(base::UTF16ToUTF8(check_box_value));

@@ -838,7 +840,9 @@ TEST_F(BrowserAccessibilityTest, TestIA2Attributes) {

checkbox.id = 3;

checkbox.SetName("Checkbox");

checkbox.role = ui::AX_ROLE_CHECK_BOX;

- checkbox.state = 1 << ui::AX_STATE_CHECKED;

+ checkbox.state = 0;

+ checkbox.AddIntAttribute(ui::AX_ATTR_CHECKED_STATE,

+ ui::AX_CHECKED_STATE_TRUE);

ui::AXNodeData root;

root.id = 1;