Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: content/renderer/accessibility/blink_ax_enum_conversion.cc

Issue 2694903010: AX checked state changes (Closed)
Patch Set: Fix android test Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/accessibility/blink_ax_enum_conversion.cc
diff --git a/content/renderer/accessibility/blink_ax_enum_conversion.cc b/content/renderer/accessibility/blink_ax_enum_conversion.cc
index e581c5108be18aee5f99a9c8c3710ab42cedc23e..0b41ddb3de1d1ecf26a0b685a2dab581a89fade3 100644
--- a/content/renderer/accessibility/blink_ax_enum_conversion.cc
+++ b/content/renderer/accessibility/blink_ax_enum_conversion.cc
@@ -10,8 +10,6 @@ namespace content {
uint32_t AXStateFromBlink(const blink::WebAXObject& o) {
uint32_t state = 0;
- if (o.isChecked())
- state |= (1 << ui::AX_STATE_CHECKED);
blink::WebAXExpanded expanded = o.isExpanded();
if (expanded) {
@@ -526,6 +524,20 @@ ui::AXInvalidState AXInvalidStateFromBlink(
return ui::AX_INVALID_STATE_NONE;
}
+ui::AXCheckedState AXCheckedStateFromBlink(
+ blink::WebAXCheckedState checked_state) {
+ switch (checked_state) {
+ case blink::WebAXCheckedFalse:
+ return ui::AX_CHECKED_STATE_FALSE;
+ case blink::WebAXCheckedTrue:
+ return ui::AX_CHECKED_STATE_TRUE;
+ case blink::WebAXCheckedMixed:
+ return ui::AX_CHECKED_STATE_MIXED;
+ }
+ NOTREACHED();
+ return ui::AX_CHECKED_STATE_FALSE;
+}
+
ui::AXSortDirection AXSortDirectionFromBlink(
blink::WebAXSortDirection sort_direction) {
switch (sort_direction) {

Powered by Google App Engine
This is Rietveld 408576698