ui/views/controls/button/checkbox.cc - Issue 2694903010: AX checked state changes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/views/controls/button/checkbox.cc

Issue 2694903010: AX checked state changes (Closed)

Patch Set: Fix compiler error Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/views/controls/button/checkbox.cc

diff --git a/ui/views/controls/button/checkbox.cc b/ui/views/controls/button/checkbox.cc

index 91d3a23f875ce24a3a4a82e3d76ade8634a2351a..e304fce36bc7d74d0a6c80f077be4f68e9c3f6f7 100644

--- a/ui/views/controls/button/checkbox.cc

+++ b/ui/views/controls/button/checkbox.cc

@@ -124,7 +124,8 @@ void Checkbox::GetAccessibleNodeData(ui::AXNodeData* node_data) {

LabelButton::GetAccessibleNodeData(node_data);

node_data->role = ui::AX_ROLE_CHECK_BOX;

if (checked())

- node_data->AddStateFlag(ui::AX_STATE_CHECKED);

+ node_data->AddIntAttribute(ui::AX_ATTR_CHECKED_STATE,

+ ui::AX_CHECKED_STATE_TRUE);

if (enabled()) {

if (checked()) {

node_data->AddIntAttribute(ui::AX_ATTR_ACTION,