third_party/WebKit/LayoutTests/accessibility/html-input-mixed.html - Issue 2694903010: AX checked state changes

Side by Side Diff: third_party/WebKit/LayoutTests/accessibility/html-input-mixed.html

Issue 2694903010: AX checked state changes (Closed)

Patch Set: Remove whitespace change Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

« no previous file with comments | « third_party/WebKit/LayoutTests/accessibility/aria-checkbox-checked-mixed-expected.txt ('k') | third_party/WebKit/LayoutTests/accessibility/html-input-mixed-expected.txt » ('j') | third_party/WebKit/Source/modules/accessibility/AXObject.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE HTML PUBLIC "-//IETF//DTD HTML//EN">

	2 <html>

	3 <head>

	4 <script src="../resources/js-test.js"></script>

	5 </head>

	6 <body id="body">

	7

	8 <input id="element1" type="checkbox" /> <!-- Will set indeterminate state via J S -->
	dmazzoni 2017/02/16 20:56:04 Maybe put this comment on the line above so it fit Maybe put this comment on the line above so it fits in 80 cols We don't have a strict rule of 80 cols for html, but it's nice since most other source files are 80 cols and the code review tool wraps at 80 by default aleventhal 2017/02/24 21:44:01 Done. Show quoted text On 2017/02/16 20:56:04, dmazzoni wrote: > Maybe put this comment on the line above so it fits in 80 cols > > We don't have a strict rule of 80 cols for html, but it's nice > since most other source files are 80 cols and the code review > tool wraps at 80 by default Done.
	9 <input id="element2" type="checkbox" /> <!-- Control-->

	10

	11 <div>

	12 <!-- Will be ::intederminate in CSS because no radio item selected yet -->

	13 <input type="radio" name="radiogroup1" />

	14 <input id="element3" type="radio" name="radiogroup1" />

	15 </div>

	16

	17 <div>

	18 <!-- NOT mixed/intederminate because group has a selected radio button -->

	19 <input type="radio" name="radiogroup2" />
	dmazzoni 2017/02/16 20:56:04 Might be nice to put an id on this one and check i Might be nice to put an id on this one and check its state too aleventhal 2017/02/24 21:44:01 Done. Show quoted text On 2017/02/16 20:56:04, dmazzoni wrote: > Might be nice to put an id on this one and check its > state too Done.
	20 <input id="element4" type="radio" checked name="radiogroup2" />

	21 </div>

	22

	23 <p id="description"></p>

	24 <div id="console"></div>

	25

	26 <script>

	27

	28 description("Check whether native mixed state is reported properly");

	29

	30 // No way currently to do this via markup, must be via JS

	31 document.getElementById('element1').indeterminate = true;
	dmazzoni 2017/02/16 20:56:04 You could put a <script> tag right after the eleme You could put a <script> tag right after the element and set it there, that might be cleaner aleventhal 2017/02/24 21:44:01 Done. Show quoted text On 2017/02/16 20:56:04, dmazzoni wrote: > You could put a <script> tag right after the element and set it > there, that might be cleaner Done.
	32

	33 if (window.accessibilityController) {

	34 for (var i = 1; i <= 4; i++) {

	35 var element = accessibilityController.accessibleElementById("element " + i);

	36 debug("Role: " + element.role);
	dmazzoni 2017/02/16 20:56:04 This is an old-style test, where you dump out text This is an old-style test, where you dump out text and check the expectations. Please write a unit-style test like aria-modal.html where you make individual assertions aleventhal 2017/02/24 21:44:01 Instead of this one, right? Show quoted text On 2017/02/16 20:56:04, dmazzoni wrote: > This is an old-style test, where you dump out text and check the > expectations. Please write a unit-style test like aria-modal.html > where you make individual assertions Instead of this one, right?
	37 debug("Mixed: " + element.isButtonStateMixed);

	38 }

	39 }

	40

	41 </script>

	42

	43 </body>

	44 </html>

OLD	NEW